Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix error when using columnGrouping with all columns hidden #6425

Merged
merged 1 commit into from Oct 7, 2022
Merged

[DataGrid] Fix error when using columnGrouping with all columns hidden #6425

merged 1 commit into from Oct 7, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Oct 7, 2022 •
edited

Cherry-pick from #6405

@alexfauquette alexfauquette changed the title [DataGrid] Fix error when using columnGrouping with all columns hidde… [DataGrid] Fix error when using columnGrouping with all columns hidden Oct 7, 2022
@alexfauquette alexfauquette mentioned this pull request Oct 7, 2022
Merged
@alexfauquette alexfauquette added the bug 🐛 Something doesn't work label Oct 7, 2022
@mui-bot
Copy link

mui-bot commented Oct 7, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 573.7 930.7 632.6 720.66 139.408
Sort 100k rows ms 741 1,038.4 741 932.9 117.356
Select 100k rows ms 188.4 364 257.2 267.06 63.683
Deselect 100k rows ms 174.4 300.4 254.3 240.28 51.764

Generated by 🚫 dangerJS against bce57f9

@alexfauquette alexfauquette merged commit ef44583 into mui:master Oct 7, 2022
@alexfauquette alexfauquette deleted the fix-column-group-error branch October 7, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexfauquette @mui-bot