Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix grid not updating state on rowCount prop change #6474

Merged
merged 6 commits into from Oct 20, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 12, 2022

Backport of #5982 to master

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features labels Oct 12, 2022
@mui-bot
Copy link

mui-bot commented Oct 12, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 523.7 1,117.2 523.7 815.94 238.321
Sort 100k rows ms 649.7 1,140.2 649.7 939.2 176.066
Select 100k rows ms 222.2 384.1 300.7 293.72 58.33
Deselect 100k rows ms 159.3 307.6 242 229.08 59.681

Generated by 🚫 dangerJS against 38b7b64

@cherniavskii cherniavskii marked this pull request as ready for review October 20, 2022 10:48
@cherniavskii cherniavskii merged commit 87e6abc into mui:master Oct 20, 2022
@cherniavskii cherniavskii deleted the rowCount-no-pagination-master branch October 20, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants