Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateRangePicker] Dates jiggle when hovering over spacing fillers in first or last row #6511

Closed
2 tasks done
paulleonartcalvo opened this issue Oct 14, 2022 · 4 comments
Closed
2 tasks done
Labels
bug 馃悰 Something doesn't work component: DateRangePicker The React component. plan: Pro Impact at least one Pro user

Comments

@paulleonartcalvo
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

When hovering over date spacing fillers in first or last row, the rest of the day/week containers jitter, shifting slightly, which causes an undesired side effect to hovering over the picker.

Expected behavior 馃

When hovering over the calendar, dates should not jitter around within the container. They should stay in position.

Steps to reproduce 馃暪

Link to live example:

Steps:

  1. Set up a date range picker with a localization provider which uses 2 input fields
  2. Click into a input field such that the date range picker appears
  3. Hover over the first or last row empty spaces

Here is a sandbox showing the behavior

Context 馃敠

I want to use the date range picker with 2 inputs, each containing either the start or end date. This is the same situation used in the Mui-X docs for basic date range picker usage. I've attempted to target the styles causing the problem and have had little success with overrides, but the event that causes the shifting is clear. The on hover event on the empty spaces adds a 1px border, shifting content downstream. I'm not sure what the 'correct' way to fix the problem is but thats where i would start looking

Screen Shot 2022-10-14 at 12 42 53 PM

Your environment 馃寧

npx @mui/envinfo
   Browser used: Chrome
  System:
    OS: macOS 12.5.1
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.14.0 - ~/.nvm/versions/node/v16.14.0/bin/npm
  Browsers:
    Chrome: 106.0.5249.103
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.6.1


Order ID 馃挸 (optional)

42126

@paulleonartcalvo paulleonartcalvo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 14, 2022
@paulleonartcalvo paulleonartcalvo changed the title [DateRangePicker]: Calendar jitters when hovering over spacing fillers in first or last row [DateRangePicker] Calendar jitters when hovering over spacing fillers in first or last row Oct 14, 2022
@paulleonartcalvo paulleonartcalvo changed the title [DateRangePicker] Calendar jitters when hovering over spacing fillers in first or last row [DateRangePicker] Calendar jiggles when hovering over spacing fillers in first or last row Oct 15, 2022
@paulleonartcalvo paulleonartcalvo changed the title [DateRangePicker] Calendar jiggles when hovering over spacing fillers in first or last row [DateRangePicker] Dates jiggle when hovering over spacing fillers in first or last row Oct 15, 2022
@LukasTy
Copy link
Member

LukasTy commented Oct 17, 2022

@paulleonartcalvo Thank you for opening this issue.
We've failed to notice the same issue appears on v5 as well.
@alexfauquette Do you think we should cherry-pick your fix into master?

@LukasTy LukasTy added bug 馃悰 Something doesn't work component: DateRangePicker The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 17, 2022
@alexfauquette
Copy link
Member

I copied the fix on master, just need the verify ti fixes the bug on the doc preview

@LukasTy
Copy link
Member

LukasTy commented Oct 17, 2022

I copied the fix on master, just need the verify ti fixes the bug on the doc preview

Just a reminder鈥攁t least for me鈥攖he issue is not visible in our doc.
Only isolated usages (i.e. playground, codesandbox) allows reproduction.

@paulleonartcalvo
Copy link
Author

paulleonartcalvo commented Oct 17, 2022

@LukasTy Yes, i found that odd as well, which is why i was hesitant to make this issue at first. Regardless, thank you all very much for getting a fix in so quickly!

@flaviendelangle flaviendelangle added the plan: Pro Impact at least one Pro user label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 Something doesn't work component: DateRangePicker The React component. plan: Pro Impact at least one Pro user
Projects
None yet
Development

No branches or pull requests

4 participants