Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Turkish (tr-TR) locale on the data grid and pickers #6542

Merged
merged 7 commits into from Oct 20, 2022

Conversation

ramazansancar
Copy link
Contributor

Signed-off-by: Ramazan SANCAR ramazansancar4545@gmail.com

Signed-off-by: Ramazan SANCAR <ramazansancar4545@gmail.com>
@flaviendelangle flaviendelangle changed the title Turkish Language finished. [I10n] Improve Turkish (tr-TR) locale on the data grid Oct 17, 2022
@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Oct 17, 2022
@mui-bot
Copy link

mui-bot commented Oct 17, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 459.7 825.9 719.4 644.28 146.221
Sort 100k rows ms 517.2 1,048.4 747.3 839.16 188.302
Select 100k rows ms 208.1 300.2 254.8 257.5 33.574
Deselect 100k rows ms 117.4 294.3 195.5 215.14 64.827

Generated by 🚫 dangerJS against 5603fab

Signed-off-by: Ramazan SANCAR <ramazansancar4545@gmail.com>
Signed-off-by: Ramazan SANCAR <ramazansancar4545@gmail.com>
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Ramazan SANCAR <ramazansancar4545@gmail.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 18, 2022
@alexfauquette
Copy link
Member

I fixed TS errors and run CI scripts

You generated tr translations for the doc, but those are in English. I revert those changes, except if you plan to translate the documentation in Turkish

@alexfauquette alexfauquette changed the title [I10n] Improve Turkish (tr-TR) locale on the data grid [I10n] Improve Turkish (tr-TR) locale on the data grid and pickers Oct 20, 2022
@alexfauquette alexfauquette changed the title [I10n] Improve Turkish (tr-TR) locale on the data grid and pickers [l10n] Improve Turkish (tr-TR) locale on the data grid and pickers Oct 20, 2022
@alexfauquette alexfauquette merged commit fa26e7e into mui:next Oct 20, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Oct 20, 2022
alexfauquette added a commit that referenced this pull request Oct 20, 2022
…6542) (#6573)

Co-authored-by: Ramazan SANCAR <ramazansancar4545@gmail.com>
@ramazansancar
Copy link
Contributor Author

I fixed TS errors and run CI scripts

You generated tr translations for the doc, but those are in English. I revert those changes, except if you plan to translate the documentation in Turkish

In fact, it created the infrastructure for translation. I would translate and PR whenever I find time.

@alexfauquette
Copy link
Member

My bad, I've merged the PR such that translations for the components are available for the community in the v6.0.0-alpha.4 and the v5.17.8

You can re-open a PR cherry-picking 8f5fb45 for that. Writing a translation is nice but I have to warn you, the documentation is not a fixed document. We improve it on a regular basis, so from time to time some sentences you translate could be replaced by new ones in English

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 21, 2022

@ramazansancar We use https://crowdin.com/project/material-ui-docs/discussions to coordinate the translation of the docs (on this PR, it's only for the component). Feel free to open a new discussion for Turkish. Please note that we are currently removing the translations on the docs, as we didn't find the ROI to be positive. We might try again to translate the docs into Chinese (only) in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants