Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix memory leak on grid unmount #6579

Merged
merged 1 commit into from Oct 24, 2022
Merged

[DataGrid] Fix memory leak on grid unmount #6579

merged 1 commit into from Oct 24, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 20, 2022 •
edited

@cherniavskii cherniavskii added performance component: data grid This is the name of the generic UI component, not the React module! labels Oct 20, 2022
@mui-bot
Copy link

mui-bot commented Oct 20, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 511.4 923.2 766.3 726.9 170.982
Sort 100k rows ms 621 1,052.9 621 888.98 151.544
Select 100k rows ms 210.6 295.7 275.6 256.9 35.103
Deselect 100k rows ms 206.9 271.4 215.8 226.86 23.614

Generated by 🚫 dangerJS against af0ef5d

@cherniavskii cherniavskii mentioned this pull request Oct 20, 2022
Closed
2 tasks
@cherniavskii cherniavskii added the regression A bug, but worse label Oct 20, 2022
@cherniavskii cherniavskii marked this pull request as ready for review October 21, 2022 09:27
@cherniavskii cherniavskii merged commit 93a58b7 into mui:master Oct 24, 2022
@cherniavskii cherniavskii deleted the fix-memory-leak branch October 24, 2022 13:04
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Oct 24, 2022
@cherniavskii
[DataGrid] Fix memory leak on grid unmount (mui#6579)
20f002a
@cherniavskii cherniavskii mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

@m4theushw m4theushw m4theushw approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! performance regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cherniavskii @mui-bot @DanailH @m4theushw