Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Update input when inputFormat is modified #6617

Merged
merged 2 commits into from Oct 25, 2022
Merged

[pickers] Update input when inputFormat is modified #6617

merged 2 commits into from Oct 25, 2022

Conversation

alexfauquette
Copy link
Member

Fix #6584

@mui-bot
Copy link

mui-bot commented Oct 24, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 609.6 1,014.8 700.4 770.84 140.136
Sort 100k rows ms 609.7 1,150.7 1,150.7 943.7 235.226
Select 100k rows ms 158.4 315 217.1 229.46 51.436
Deselect 100k rows ms 166.2 292.3 200.7 211.7 45.651

Generated by 🚫 dangerJS against bc6cf4e

@alexfauquette alexfauquette added the bug 🐛 Something doesn't work label Oct 24, 2022
@flaviendelangle
Copy link
Member

Should we port it to v6 to avoid having v5 only code ?

@alexfauquette
Copy link
Member Author

Yes, will cherry-pick it with #6618

@alexfauquette alexfauquette merged commit 503988d into mui:master Oct 25, 2022
@alexfauquette alexfauquette deleted the fix-format-update branch October 25, 2022 07:39
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Oct 25, 2022
@alexfauquette
[pickers] Update input when inputFormat is modified (mui#6617)
80c782f
@alexfauquette alexfauquette mentioned this pull request Oct 26, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfauquette @mui-bot @flaviendelangle