New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Ignore milliseconds in mask logic #6618
Conversation
These are the results for the performance tests:
|
Would it make sense to close #6587 with the assumption that https://next.mui.com/x/react-date-pickers/time-field/ fixes the issue. Or have it on hold for once it eventually fixes it? I'm asking because if the mask logic is eventually going away, I doubt we should fix a single bug related to it. |
Not being able to do backspace is a big bug, that's why I investigated. But yes, mask logic will be removed. That's why I did a quick fix without adding tests |
Given that the migration from v5 to v6 is a big one, I would be in favor of doing this kind of fixes on v5. |
The context for my comment wasn't really about this PR specifically, but to use it as a case study for a larger topic: the exploit vs. explore ressource allocation tradeoff. I think that the opposite of the points made could be argued:
Personally 👍 to fix regressions, and 👍 to focus more on the new implementations ("focus" as saying no to the rest). For the pickers, specifically, I think that it would be great to iterate enough to reach the point where we are confident that once we make it stable, we can resist breaking changes long enough to reach >80% of adoption of v6.x. I don't think that we had this for a very long time, the versions has been spread. |
This update introduced an issue when using Luxon.... Luxon equality takes into consideration the zone on its DateTime object. If I change the zone (e.g. through an accompanying zone selector component), this new equality check passes instead of fails, resulting in the rendered input string not updating.... any suggested workarounds? |
Fix #6587
Maybe a better approach would be that date parsing ignore the milliseconds such that we can always use
isEqual
without having to worry about those miliseconds