Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix setRows method not persisting new rows data after loading prop change #6637

Merged

Conversation

cherniavskii
Copy link
Member

Backport of #6493 to master branch

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse feature: State management Related to the data grid State management feature labels Oct 26, 2022
@mui-bot
Copy link

mui-bot commented Oct 26, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 472.9 891.4 589.4 642.48 163.713
Sort 100k rows ms 588.6 1,127.7 761.4 837.18 176.772
Select 100k rows ms 157.1 233.6 215.9 202.1 28.297
Deselect 100k rows ms 113.4 282.5 163.6 177.7 59.871

Generated by 🚫 dangerJS against 038653d

@cherniavskii cherniavskii merged commit 8383700 into mui:master Oct 26, 2022
@cherniavskii cherniavskii deleted the setRows-with-loading-prop-master branch October 26, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: State management Related to the data grid State management feature regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants