Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix row selection when clicking blank cell #7056

Merged
merged 1 commit into from Dec 1, 2022
Merged

[DataGrid] Fix row selection when clicking blank cell #7056

merged 1 commit into from Dec 1, 2022

Conversation

m4theushw
Copy link
Member

Backports #6974

@yami03 @m4theushw
[DataGrid] Fix row selection when clicking blank cell (mui#6974)
50faef3 
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! cherry-pick The PR was cherry-picked from the next branch labels Dec 1, 2022
@mui-bot
Copy link

mui-bot commented Dec 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 492.3 737.3 569 606.24 95.736
Sort 100k rows ms 560.4 1,044.2 719.3 822.32 174.401
Select 100k rows ms 203.4 249.3 219.7 222.86 15.845
Deselect 100k rows ms 125 220.5 189.1 176.12 32.584

Generated by 🚫 dangerJS against 50faef3

@m4theushw m4theushw merged commit 74127bb into mui:master Dec 1, 2022
@m4theushw m4theushw deleted the row-selection-blank-cell-v5 branch December 1, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick The PR was cherry-picked from the next branch component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4theushw @mui-bot @yami03