[DateTimePicker] Fix how the component is exported #7172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keal Jones <41018730+kealjones-wk@users.noreply.github.com>
|
These are the results for the performance tests:
|
zannager
added
the
component: pickers
flaviendelangle
approved these changes
Dec 13, 2022
flaviendelangle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimePickers export pattern doesn't match that of all the other x-date-picker components.
This change fixes an issue with react-docgen-typescript being able to locate the component. I am already in the process of looking for a fix in react-docgen-typescript but its not as simple. This change over here seems small enough and has no impact and would improve consistency, so maybe we could get this in in the meantime?
Examples of other component exports:
ClockPicker
CalendarPicker
DatePicker
DesktopDateTimePicker
DesktopDatePicker
DesktopTimePicker
LocalizationProvider
MobileDatePicker
MobileTimePicker
MobileDateTimePicker
MonthPicker
PickersActionBar
PickersDay
StaticDatePicker
StaticDateTimePicker
StaticTimePicker
TimePicker
YearPicker
Signed-off-by: Keal Jones 41018730+kealjones-wk@users.noreply.github.com