Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Use row ID as key of the detail panels #7311

Merged
merged 1 commit into from Dec 23, 2022
Merged

[DataGridPro] Use row ID as key of the detail panels #7311

merged 1 commit into from Dec 23, 2022
+16 −2

Conversation

m4theushw
Copy link
Member

Backports #7302

@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! cherry-pick The PR was cherry-picked from the next branch labels Dec 23, 2022
@mui-bot
Copy link

mui-bot commented Dec 23, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 713.5 1,055.5 713.7 842.62 126.862
Sort 100k rows ms 688.2 1,381.3 1,381.3 992.62 246.503
Select 100k rows ms 232 389.8 268 287.14 55.245
Deselect 100k rows ms 173.3 296.6 218.9 232.76 47.143

Generated by 🚫 dangerJS against b6b958f

@m4theushw m4theushw merged commit 3fe5d83 into mui:master Dec 23, 2022
@m4theushw m4theushw deleted the detail-panel-key-v5 branch December 23, 2022 22:10
m4theushw added a commit to DanailH/material-ui-x that referenced this pull request Dec 23, 2022
@m4theushw
Include mui#7311
c2f5a33 
Signed-off-by: Matheus Wichman <matheushw@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick The PR was cherry-picked from the next branch component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4theushw @mui-bot