Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Grid flickering twice on new grid rows input #7792

Closed
2 tasks done
harvey56 opened this issue Feb 2, 2023 · 2 comments
Closed
2 tasks done

Data Grid flickering twice on new grid rows input #7792

harvey56 opened this issue Feb 2, 2023 · 2 comments
Labels
component: data grid This is the name of the generic UI component, not the React module!

Comments

@harvey56
Copy link

harvey56 commented Feb 2, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 馃暪

Link to live example:

Steps:
1.
2.
3.

Current behavior 馃槸

I have a DataGrid whose data content (rows) is regularly updated (with a timer) via a prop of its parent component.

When new data (rows in the DataGrid componenent) comes in, will first re-render with empty content (including row ids), then with the updated content, then with empty content again, then with the updated content again.

So it appears as if the grid content flickers twice before persistently showing.

Expected behavior 馃

Expected behavior is that nothing flickers.

Context 馃敠

No response

Your environment 馃寧

npx @mui/envinfo
System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
  Binaries:
    Node: 18.9.0 - ~/.nvm/versions/node/v18.9.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.9.0/bin/yarn
    npm: 8.19.1 - ~/.nvm/versions/node/v18.9.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox: Not Found
  npmPackages:
    @emotion/react: ^11.10.5 => 11.10.5 
    @emotion/styled: ^11.10.5 => 11.10.5 
    @mui/base:  5.0.0-alpha.106 
    @mui/core-downloads-tracker:  5.10.14 
    @mui/icons-material: ^5.10.9 => 5.10.14 
    @mui/material: ^5.10.13 => 5.10.14 
    @mui/private-theming:  5.10.14 
    @mui/styled-engine:  5.10.14 
    @mui/system:  5.10.14 
    @mui/types:  7.2.1 
    @mui/utils:  5.10.14 
    @mui/x-data-grid: ^5.17.12 => 5.17.14 
    @types/react: ^18.0.11 => 18.0.25 
    react: ^18.2.0 => 18.2.0 
    react-dom: ^18.2.0 => 18.2.0 
    typescript: ^4.7.3 => 4.9.3

Order ID 馃挸 (optional)

No response

@harvey56 harvey56 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 2, 2023
@harvey56
Copy link
Author

harvey56 commented Feb 2, 2023

Looks like problem is solved 馃憣. I was using version 5.17.12. Upgrading to version 5.17.21 helped fixing it. There must have been some commit about this bug sometime between 5.17.12 and 5.17.21

There was no mention of flickering in the issue reporting history, that's why I thought it was still an issue today.

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Feb 2, 2023
@cherniavskii
Copy link
Member

Hi Harvey,
Indeed, this was fixed in #7155 and released in https://github.com/mui/mui-x/releases/tag/v5.17.16
I'm glad the upgrade helped!

@cherniavskii cherniavskii removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants