Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array for sx prop #52

Merged
merged 10 commits into from
May 6, 2024
Merged

Support array for sx prop #52

merged 10 commits into from
May 6, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 6, 2024 •
edited

Require #51 to be merged first.

closes #46, please see the test cases.

@siriwatknp siriwatknp added the enhancement This is not a bug, nor a new feature label May 6, 2024
@siriwatknp siriwatknp requested a review from brijeshb42 May 6, 2024 08:32
brijeshb42
brijeshb42 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Overall looks good. Thanks for implementing this. I have a separate track for improving all the manual transforms that we are doing in the processor, but perhaps that can be done separately.

@siriwatknp siriwatknp merged commit bfca706 into master May 6, 2024
17 checks passed
@siriwatknp siriwatknp deleted the feat/sx-array branch May 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42 brijeshb42 approved these changes

Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support array in sx prop
2 participants
@siriwatknp @brijeshb42