Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure static interface methods in SDK are backported properly #169

Open
Noisyfox opened this issue Apr 2, 2022 · 1 comment
Open

Make sure static interface methods in SDK are backported properly #169

Noisyfox opened this issue Apr 2, 2022 · 1 comment
Assignees
@Noisyfox
Labels
bug component/gradle-plugin prio/blocker
Projects
MOE
Milestone
1.9.1

Comments

@Noisyfox
Copy link
Member

Noisyfox commented Apr 2, 2022

No description provided.

@Noisyfox Noisyfox added this to the 1.9.1 milestone Apr 2, 2022
@Noisyfox Noisyfox self-assigned this Apr 2, 2022
@Noisyfox Noisyfox added this to To do in MOE Apr 2, 2022
@Noisyfox
Copy link
Member Author

Noisyfox commented Apr 2, 2022 •
edited

This can be done by running the backport as a separate step after proguard, i.e., run proguard twice, which:

  1. Do shrinking & obfuscating as configured, with proper proguard level
  2. Then run proguard with everything disabled except backporting, with everything (i.e., both app code and MOE core/ios jars) as inputs.

This will make the build time longer, as now no pre-desugaring can be made to MOE core and iOS jars, but this also reduces the SDK size as we no longer need to ship the pre-dexed cores.

@Noisyfox Noisyfox moved this from To do to In progress in MOE Apr 2, 2022
Noisyfox added a commit to multi-os-engine/moe-tools-classvalidator that referenced this issue Apr 2, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Do not process classes from `ja…
983525d 
…va.*`
Noisyfox added a commit to multi-os-engine/moe-sdk-publisher that referenced this issue Apr 2, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) No pre-desugar and pre-dex needed
c19cc67
Noisyfox added a commit to multi-os-engine/moe-core that referenced this issue Apr 2, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Don't backport during the progu…
d0b0a9d 
…ard task
Noisyfox added a commit to multi-os-engine/moe-plugin-gradle that referenced this issue Apr 2, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Add desugar task
ba5a32f
Noisyfox added a commit to multi-os-engine/moe-plugin-gradle that referenced this issue Jun 12, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Generate desugared application …
db01d96 
…jar and runtime jar separately to avoid proguard's class dup problem
Noisyfox added a commit to multi-os-engine/moe-plugin-gradle that referenced this issue Jun 12, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Generate dex files separately t…
a486c8c 
…o avoid class dup problem
Noisyfox added a commit to multi-os-engine/moe-plugin-gradle that referenced this issue Jun 12, 2022
@Noisyfox
(multi-os-engine/multi-os-engine#169) Fix empty input file error when…
968c32e 
… build project again
Noisyfox added a commit to multi-os-engine/moe-core that referenced this issue Jul 23, 2022
@Noisyfox
Merge commit 'bccf53124373877b478bfd5f0959e44c40fb4027' into moe-svm
f7b2a35 
* commit 'bccf53124373877b478bfd5f0959e44c40fb4027':
  Apply spotless format
  Add notes about spotless and the format file
  Format javadoc comments too - Mistake by mine, that it wasn't before
  Use spotless for formatting the bindings - gradle needed to be updated to at least 6.1.1 to support spotless
  Exclude i386 from simulator build
  (multi-os-engine/multi-os-engine#169) Don't backport during the proguard task
  Exclude empty dirs from final jars
  Start 1.9.1 dev
  Start next dev iteration
  Release 1.9.0
  Build core with proper version number

# Conflicts:
#	moe.apple/moe.core.native/moe.sdk/moe.sdk.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Noisyfox Noisyfox

Labels
bug component/gradle-plugin prio/blocker
Projects
MOE
Status: In progress
MOE
In progress
Milestone
1.9.1
Development

No branches or pull requests
1 participant
@Noisyfox