Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: What should "java.vm.name" report #184

Open
Berstanio opened this issue Aug 23, 2022 · 0 comments
Open

Discussion: What should "java.vm.name" report #184

Berstanio opened this issue Aug 23, 2022 · 0 comments

Comments

@Berstanio
Copy link

Currently the "java.vm.name" property reports "Dalvik", as android does. https://github.com/multi-os-engine/libcore/blob/eae58129e020f95e9b4a506cea4cc90cc21b09a3/luni/src/main/java/java/lang/System.java#L769
This means, some third party libs that have android specific code pathes, will recognize MOE as android, e.g. okhttp3/retrofit.

This can be working, if the code path is just about libcore specific implementations. However, if the code path relies of something android os specific, the code path will fail.

What should we do about it? Don't report "Dalvik"? Make it configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant