Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish clear ownership of js-multiformats #273

Open
2 tasks
BigLep opened this issue Sep 26, 2023 · 2 comments · May be fixed by #274
Open
2 tasks

Establish clear ownership of js-multiformats #273

BigLep opened this issue Sep 26, 2023 · 2 comments · May be fixed by #274

Comments

@BigLep
Copy link

BigLep commented Sep 26, 2023

Background

The lack of unified consensus of #249 highlighted that there is a lack of clarity on the ownership of this repo. CODEOWNERS isn't defined, and there isn't an understanding of how owners should handle disagreements. Some of the main contributors of this repo over the last 12 months are individuals who do this on the side of other team work they have (@rvagg and @Gozala - thank you!). Others help maintain here as part of their full-time maintenance and development of libraries that consume this repo (e.g., js-libp2p, Helia).

Done criteria

  1. Create CODEOWNERs
  2. Document what is expected of a CODEOWNER
  3. Document where triage and synchronous decisions for this repo are handled

Proposal

  1. CODEOWNERs for now should be existing maintainers who have stayed involved with the project (i.e., @rvagg, @Gozala) or consuming projects that have stayed involved in the project (js-libp2p, Helia). (It's fine if any of these individuals/groups want to back out.). Lets handle this in set up CODEOWNERS for js-multiformats github-mgmt#83
  2. In the absence of another venue currently and the general change happening to PL EngRes teams as they "nucleate" out from PL, I'd like to propose that we house triage and synchronous conversations as part of js-libp2p triage since it is a multiple organization venue that meets weekly. (We know this time is not conducive for everyone, so we are also happy to find an alternative venue.)
  3. Concerning the expectations of codeowners, I don't think we need to be too prescriptive here, but at the minimum, I think they should engage on open issues and PRs when pinged within a week. Ideally they would also proactively engage on issues and PRs and participate in triage.

Proposed actions

@BigLep
Copy link
Author

BigLep commented Sep 26, 2023

Another couple of comments:

  1. It's recognized that the number consumers of this repo is large (https://github.com/multiformats/js-multiformats/network/dependents?dependent_type=PACKAGE&package_id=UGFja2FnZS0xMTU3NjI2MTU5 and https://www.npmjs.com/browse/depended/multiformats ). As a result, changes need to be made with care here.
  2. I'm not proposing more formal governance at the moment given changes here tend to be "low".
  3. The proposal doesn't really talk about how someone else becomes a codeowner. I think that would ultimately be up to the majority vote of the current codeowners (where codeowner teams count as a single vote).

@rvagg
Copy link
Member

rvagg commented Sep 27, 2023

ACK and 👍

BigLep added a commit that referenced this issue Sep 27, 2023
Make a note about who the owners/maintainers are and where they gather.
This relates to #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants