Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDG_CONFIG_HOME is not respected #6029

Open
eukara opened this issue Jan 10, 2023 · 3 comments · May be fixed by #6186
Open

XDG_CONFIG_HOME is not respected #6029

eukara opened this issue Jan 10, 2023 · 3 comments · May be fixed by #6186
Labels
bug A bug (error) in the software client good first issue Good for first-time contributors

Comments

@eukara
Copy link

eukara commented Jan 10, 2023

Description

Currently the Mumble client hard-codes the location of the Mumble config directory to be located at ~/.config/mumble when it should read the XDG_CONFIG_HOME environment instead.

mumble/src/mumble/Database.cpp

Line 50 in f73db9d

datapaths << QDir::homePath() + QLatin1String("/.config/Mumble");

Steps to reproduce

  1. Changing XDG_CONFIG_HOME and move ~/.config to set location.
  2. Launch Mumble client.
  3. Mumble will give an alert about the database file being missing.

Mumble version

1.4.0

Mumble component

Client

OS

Linux

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response
@eukara eukara added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Jan 10, 2023
@Krzmbrzl Krzmbrzl added client good first issue Good for first-time contributors and removed triage This issue is waiting to be triaged by one of the project members labels Jan 11, 2023
@supersanban supersanban linked a pull request Aug 4, 2023 that will close this issue
Draft
1 task
@supersanban
Copy link

Hi, I wanted to contribute to resolving this issue and hence have raised a PR for this. Could you take a look at the PR please. Thank you.

supersanban added a commit to supersanban/mumble that referenced this issue Aug 5, 2023
@supersanban
FIX(client) : Fixed config directory path assignment
dc7c958 
Config directory path in Linux should be picked from XDG_CONFIG_HOME environment variable. Fixes mumble-voip#6029
@eukara
Copy link
Author

eukara commented Aug 5, 2023

Thank you, I left a comment on the PR commit in question with some feedback.

supersanban added a commit to supersanban/mumble that referenced this issue Aug 5, 2023
@supersanban
FIX(client) : Fixed config directory path assignment
bac0167 
Config directory path in Linux should be picked from XDG_CONFIG_HOME environment variable. Fixes mumble-voip#6029
supersanban added a commit to supersanban/mumble that referenced this issue Aug 7, 2023
@supersanban
FIX(client): Fixed config directory path assignment
ac70883 
Config directory path in Linux should be picked from XDG_CONFIG_HOME environment variable

Fixes mumble-voip#6029
supersanban added a commit to supersanban/mumble that referenced this issue Aug 7, 2023
@supersanban
FIX(client): Fixed config directory path assignment
bf2a73b 
Config directory path in Linux should be picked from XDG_CONFIG_HOME environment variable

Fixes mumble-voip#6029
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Aug 7, 2023

No need to comment here - I get notifications for anything that happens in the PR anyway

supersanban added a commit to supersanban/mumble that referenced this issue Aug 7, 2023
@supersanban
FIX(client): Fixed config directory path assignment
57ab96c 
Config directory path in Linux should be picked from XDG_CONFIG_HOME environment variable

Fixes mumble-voip#6029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug (error) in the software client good first issue Good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX(client) : Fixed config directory path assignment supersanban/mumble
3 participants
@Krzmbrzl @supersanban @eukara