Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepFilterNet noise suppression #6299

Open
aksdb opened this issue Jan 5, 2024 · 3 comments
Open

Add DeepFilterNet noise suppression #6299

aksdb opened this issue Jan 5, 2024 · 3 comments
Labels
audio client feature-request This issue or PR deals with a new feature

Comments

@aksdb
Copy link

aksdb commented Jan 5, 2024

Context

Improve voice quality further in noisy environments.

Description

In addition to RNNoise, add the (also) open source DeepFilterNet noise suppression filter to the Mumble client, which does seem to yield very good results in audio quality.

Mumble component

Client

OS-specific?

No

Additional information

No response

@aksdb aksdb added feature-request This issue or PR deals with a new feature triage This issue is waiting to be triaged by one of the project members labels Jan 5, 2024
@Krzmbrzl Krzmbrzl added client audio and removed triage This issue is waiting to be triaged by one of the project members labels Jan 5, 2024
@DarkDefender
Copy link
Contributor

Just to summarize the discussion in #6292:

Moving forward, Mumble is planning to have the audio (output, input, and plugins) be handled by:
https://github.com/mumble-voip/libcrossaudio

So far the only API that DeepFilterNet exposes seems to be LADSPA as you can already use it as a plugin with pipewire.
If LADSPA is easily usable cross platform, then we could implement this API in libcrossaudio and that way get a audio plugin system "for free".

Of course mumble would ship with some default plugins so that users don't have to download the DeepFilterNet plugin themselves.

@roshan-orlando
Copy link

Hi, I am new to contributing and would love to give this a shot if that is okay?

@Krzmbrzl
Copy link
Member

This will likely be a complex thing to implement that'll require a good understanding of the current code base. I wouldn't recommend it for someone with no prior experience in Mumble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

No branches or pull requests

4 participants