Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local-muted users keying up triggers attenuation #6247

Open
imaspeer opened this issue Oct 24, 2023 · 4 comments · May be fixed by #6394
Open

Local-muted users keying up triggers attenuation #6247

imaspeer opened this issue Oct 24, 2023 · 4 comments · May be fixed by #6394
Assignees
@blahnikkai
Labels
audio bug A bug (error) in the software client good first issue Good for first-time contributors

Comments

@imaspeer
Copy link

Description

When you local mute a user, you no longer hear them (as intended), but the attenuation feature is still triggered, lowering your other apps volume, when they key up.

I can't think of a situation where this behavior would be useful, and it is annoying when you have e.g. someone constantly keying up without speaking (which usually takes a while to be noticed by server moderators if they aren't using attenuation themselves).

Steps to reproduce

  1. In the settings window, Audio Output tab, under Attenuation, make sure "while other users talk" is enabled.
  2. Join a server and a channel with at least one other user.
  3. Local mute someone in the channel.
  4. Have the local-muted user key up (they don't need to actually talk).

Mumble version

1.5.517

Mumble component

Client

OS

Linux

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response
@imaspeer imaspeer added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Oct 24, 2023
@Hartmnt Hartmnt added client audio good first issue Good for first-time contributors and removed triage This issue is waiting to be triaged by one of the project members labels Oct 24, 2023
@blahnikkai
Copy link

Hi, can I be assigned this issue? This will be my first time contributing to an open-source project.

@Krzmbrzl
Copy link
Member

There you go. Thanks for chiming in!

@blahnikkai
Copy link

Does the attenuation feature work on MacOS?

@Krzmbrzl
Copy link
Member

I don't actually know - it might be that it doesn't 👀
Unfortunately, nobody answered me when I asked on our Matrix channel 🤷

jlallas384 added a commit to jlallas384/mumble that referenced this issue Apr 14, 2024
@jlallas384
FIX(client): Prevent local muted users from triggering attenuation
a11489f 
When 'while others users talk' attenuation is enabled, unmuted users
still trigger attenuation even if they are locally muted.

The fix is don't add local muted users' audio source to the mixing
for the audio output

Fixes mumble-voip#6247
@jlallas384 jlallas384 linked a pull request Apr 14, 2024 that will close this issue
Open
1 task
jlallas384 added a commit to jlallas384/mumble that referenced this issue Apr 17, 2024
@jlallas384
FIX(client): Prevent local muted users from triggering attenuation
d37b374 
When 'while others users talk' attenuation is enabled, unmuted users
still trigger attenuation even if they are locally muted.

The fix is don't add local muted users' audio source to the mixing
for the audio output

Fixes mumble-voip#6247
jlallas384 added a commit to jlallas384/mumble that referenced this issue Apr 17, 2024
@jlallas384
FIX(client): Prevent local muted users from triggering attenuation
bad660f 
When 'while others users talk' attenuation is enabled, unmuted users
still trigger attenuation even if they are locally muted.

The fix is don't add local muted users' audio source to the mixing
for the audio output

Fixes mumble-voip#6247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blahnikkai blahnikkai

Labels
audio bug A bug (error) in the software client good first issue Good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX(client): Prevent local muted users from triggering attenuation jlallas384/mumble
4 participants
@Hartmnt @Krzmbrzl @imaspeer @blahnikkai