{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":334515490,"defaultBranch":"master","name":"garble-fork","ownerLogin":"mvdan","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-01-30T21:30:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3576549?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1714047724.0","currentOid":""},"activityList":{"items":[{"before":"861be86339016341b013812497f35abc4c0434e2","after":"ad151eb85f72bc08c156e4a182227c525593b568","ref":"refs/heads/readme-exceptions","pushedAt":"2024-04-25T12:22:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"README: clarify that we have no plans to exclude files or packages\n\nThis is a common question in the issue tracker: #631, #777, #802, #844.\nWhile here, tweak the wording and formatting in the section as well.","shortMessageHtmlLink":"README: clarify that we have no plans to exclude files or packages"}},{"before":"6d527635b312b3ef575d6c40c899d6992ab8e5e5","after":null,"ref":"refs/heads/pointer-regexp","pushedAt":"2024-04-25T12:22:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"6d527635b312b3ef575d6c40c899d6992ab8e5e5","ref":"refs/heads/pointer-regexp","pushedAt":"2024-04-25T09:08:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"make pointer regular expressions more flexible\n\nWe just got a failure on Mac on CI with pointers past eight digits:\n\n    (0x10432dec0,0x10433c690)\n\nUse `[[:xdigit:]]+` consistently.","shortMessageHtmlLink":"make pointer regular expressions more flexible"}},{"before":null,"after":"861be86339016341b013812497f35abc4c0434e2","ref":"refs/heads/readme-exceptions","pushedAt":"2024-04-25T08:42:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"README: clarify that we have no plans to exclude files or packages\n\nThis is a common question in the issue tracker: #631, #777, #802, #844.\nWhile here, tweak the wording and formatting in the section as well.","shortMessageHtmlLink":"README: clarify that we have no plans to exclude files or packages"}},{"before":"c0303d87ca7a52764ae741390b4f2f9e85e320af","after":null,"ref":"refs/heads/tweaks","pushedAt":"2024-03-30T00:38:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"c0303d87ca7a52764ae741390b4f2f9e85e320af","ref":"refs/heads/tweaks","pushedAt":"2024-03-08T11:23:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"all: use cmd.Environ rather than os.Environ\n\nAdded in Go 1.19, this keeps os/exec's default environment logic,\nsuch as ensuring that $PWD is always set.","shortMessageHtmlLink":"all: use cmd.Environ rather than os.Environ"}},{"before":"bee109515ba8846549fc3dbb532b6ec41fd1495b","after":null,"ref":"refs/heads/quicktest","pushedAt":"2024-03-08T11:13:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"bee109515ba8846549fc3dbb532b6ec41fd1495b","ref":"refs/heads/quicktest","pushedAt":"2024-02-25T23:12:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"switch frankban/quicktest for go-quicktest/qt\n\nThe latter is newer and uses generics.","shortMessageHtmlLink":"switch frankban/quicktest for go-quicktest/qt"}},{"before":"d6e83a05ea656dd46424fbf90b2ddc0f3a598029","after":null,"ref":"refs/heads/obfuscate-syscall","pushedAt":"2024-02-25T23:09:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"9e9c6235febfa5a6ea9d87569ea67d4cca0721a9","after":null,"ref":"refs/heads/go-alias-panic","pushedAt":"2024-02-25T23:09:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"75fb58c0f4dcfa70e0be848afdc1fa000a8260df","after":null,"ref":"refs/heads/followup","pushedAt":"2024-02-25T23:09:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"75fb58c0f4dcfa70e0be848afdc1fa000a8260df","ref":"refs/heads/followup","pushedAt":"2024-02-18T11:50:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"use types.Info.PkgNameOf\n\nIt accomplishes the same Implicits/Defs logic we were doing here.","shortMessageHtmlLink":"use types.Info.PkgNameOf"}},{"before":null,"after":"9e9c6235febfa5a6ea9d87569ea67d4cca0721a9","ref":"refs/heads/go-alias-panic","pushedAt":"2024-02-18T10:31:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"fail early if we know we lack Go linker patches\n\nRight now, we only have linker patches for Go 1.22.x.\nWe only ever maintain those for one or two major Go versions at a time.\n\nIf a user tries to use the Go toolchain from 1.21, we already fail\nwith \"Go version too old\" messages early on, but we don't for 1.23,\ncausing a relatively confusing error later on when we link a binary:\n\n    cannot get modified linker: cannot retrieve linker patches: open patches/go1.23: file does not exist\n\nInstead, fail early and with a good error message.","shortMessageHtmlLink":"fail early if we know we lack Go linker patches"}},{"before":"093bc4ddcd24e3f430456906a2ff3cf81507c94b","after":"d6e83a05ea656dd46424fbf90b2ddc0f3a598029","ref":"refs/heads/obfuscate-syscall","pushedAt":"2024-02-18T09:27:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"obfuscate syscall again to fix x/sys/unix\n\nWhen updating Garble to support Go 1.22.0, CI on MacOS spotted\nthat the syscall package was failing to build given that it uses\nassembly code which is only allowed in some std packages.\n\nThat allowlist is based on import paths, and we were obfuscating\nthe syscall package's import path, so that was breaking GOOS=darwin.\nAs a fix, I added syscall to runtimeAndDeps to not obfuscate it.\n\nThat wasn't a great fix; it's not part of runtime and its dependencies,\nand there's no reason we should avoid obfuscating the package contents.\nNot obfuscating the contents in fact broke x/sys/unix,\nas it contains a copy of syscall.Rlimit which it type converted with.\n\nUndo that fix and reinstate the gogarble.txtar syscall test.\nImplement the fix where we only leave syscall's import path alone.\nAdd a regression test, and add a note about adding x/net and x/sys\nto check-third-party.sh so that we can catch these bugs earlier.\n\nFixes #830.","shortMessageHtmlLink":"obfuscate syscall again to fix x/sys/unix"}},{"before":null,"after":"093bc4ddcd24e3f430456906a2ff3cf81507c94b","ref":"refs/heads/obfuscate-syscall","pushedAt":"2024-02-18T00:12:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"obfuscate syscall again to fix x/sys/unix\n\nWhen updating Garble to support Go 1.22.0, CI on MacOS spotted\nthat the syscall package was failing to build given that it uses\nassembly code which is only allowed in some std packages.\n\nThat allowlist is based on import paths, and we were obfuscating\nthe syscall package's import path, so that was breaking GOOS=darwin.\nAs a fix, I added syscall to runtimeAndDeps to not obfuscate it.\n\nThat wasn't a great fix; it's not part of runtime and its dependencies,\nand there's no reason we should avoid obfuscating the package contents.\nNot obfuscating the contents in fact broke x/sys/unix,\nas it contains a copy of syscall.Rlimit which it type converted with.\n\nUndo that fix and reinstate the gogarble.txtar syscall test.\nImplement the fix where we only leave syscall's import path alone.\nAdd a regression test, and add a note about adding x/net and x/sys\nto check-third-party.sh so that we can catch these bugs earlier.\n\nFixes #830.","shortMessageHtmlLink":"obfuscate syscall again to fix x/sys/unix"}},{"before":"d342de40990fafc6ab5d4542cf67b7abd9fe1d8a","after":"69bc62c56cd253bc68ca75a59735f3f15d3567cb","ref":"refs/heads/master","pushedAt":"2024-02-17T23:46:21.000Z","pushType":"push","commitsCount":194,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"start using some Go 1.22 features\n\nWe no longer need to worry about the scope of range variables,\nwe can iterate over integers directly, and we can use cmp.Or too.\n\nI haven't paid close attention to using these everywhere.\nThis is mainly testing out the new features where I saw some benefit.","shortMessageHtmlLink":"start using some Go 1.22 features"}},{"before":"a84bc0e90e0c07b3b6d945f9c74f7553da3d71db","after":null,"ref":"refs/heads/drop-go1.21","pushedAt":"2024-02-17T23:46:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"3d266c5cfe1a31fdafa0cc9a5827e1c25045e3d1","after":"a84bc0e90e0c07b3b6d945f9c74f7553da3d71db","ref":"refs/heads/drop-go1.21","pushedAt":"2024-02-11T21:50:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"start using some Go 1.22 features\n\nWe no longer need to worry about the scope of range variables,\nwe can iterate over integers directly, and we can use cmp.Or too.\n\nI haven't paid close attention to using these everywhere.\nThis is mainly testing out the new features where I saw some benefit.","shortMessageHtmlLink":"start using some Go 1.22 features"}},{"before":null,"after":"3d266c5cfe1a31fdafa0cc9a5827e1c25045e3d1","ref":"refs/heads/drop-go1.21","pushedAt":"2024-02-11T21:44:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"start using some Go 1.22 features\n\nWe no longer need to worry about the scope of range variables,\nwe can iterate over integers directly, and we can use cmp.Or too.\n\nI haven't paid close attention to using these everywhere.\nThis is mainly testing out the new features where I saw some benefit.","shortMessageHtmlLink":"start using some Go 1.22 features"}},{"before":"10a77a21afdbcf59b2c07e935f43ebd066debac3","after":null,"ref":"refs/heads/prepare-release","pushedAt":"2024-02-10T10:29:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"377c9cb5d126c9ccd5381d4fa0ed676d185ff745","after":"10a77a21afdbcf59b2c07e935f43ebd066debac3","ref":"refs/heads/prepare-release","pushedAt":"2024-02-08T15:22:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"fix building for GOOS=darwin on Go 1.22.0\n\nIt seems like building with Go 1.22.0 for GOOS=darwin started\nrunning into some issues with the syscall package's use of ABIInternal\nin assembly source code:\n\n    > exec garble build\n    [stderr]\n    # syscall\n    [...].s:16: ABI selector only permitted when compiling runtime, reference was to \"runtime.entersyscall\"\n\nThe error can be reproduced from another platform like GOOS=linux\nas long as we have any test that cross-compiles std to GOOS=darwin.\nWe had crossbuild.txtar which only ensured we covered GOOS=windows\nand GOOS=linux, so add a third case to ensure MacOS is covered too.\n\nThis will slow down the tests a bit, but is important for the sake\nof ensuring that we catch these bugs early, even without MacOS on CI.\nIn fact, we hadn't caught this earlier for Go 1.22 precisely because\non CI we only tested on Go tip with GOOS=linux, for the sake of speed.\n\nAdding the rest of the package import paths from objabi.allowAsmABIPkgs\nto our runtimeAndDeps generated map solves this error.","shortMessageHtmlLink":"fix building for GOOS=darwin on Go 1.22.0"}},{"before":"5c1a01c67c6aa7b5c524ab468a1dd37fad5d1477","after":"377c9cb5d126c9ccd5381d4fa0ed676d185ff745","ref":"refs/heads/prepare-release","pushedAt":"2024-02-08T14:45:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"fix building for GOOS=darwin on Go 1.22.0\n\nIt seems like building with Go 1.22.0 for GOOS=darwin started\nrunning into some issues with the syscall package's use of ABIInternal\nin assembly source code:\n\n    > exec garble build\n    [stderr]\n    # syscall\n    [...].s:16: ABI selector only permitted when compiling runtime, reference was to \"runtime.entersyscall\"\n\nThe error can be reproduced from another platform like GOOS=linux\nas long as we have any test that cross-compiles std to GOOS=darwin.\nWe had crossbuild.txtar which only ensured we covered GOOS=windows\nand GOOS=linux, so add a third case to ensure MacOS is covered too.\n\nThis will slow down the tests a bit, but is important for the sake\nof ensuring that we catch these bugs early, even without MacOS on CI.\nIn fact, we hadn't caught this earlier for Go 1.22 precisely because\non CI we only tested on Go tip with GOOS=linux, for the sake of speed.\n\nAdding the rest of the package import paths from objabi.allowAsmABIPkgs\nto our runtimeAndDeps generated map solves this error.","shortMessageHtmlLink":"fix building for GOOS=darwin on Go 1.22.0"}},{"before":null,"after":"5c1a01c67c6aa7b5c524ab468a1dd37fad5d1477","ref":"refs/heads/prepare-release","pushedAt":"2024-02-07T11:21:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"CHANGELOG: draft release notes for v0.12.0","shortMessageHtmlLink":"CHANGELOG: draft release notes for v0.12.0"}},{"before":"20718b1e48c2870a81b0e3423ab17a744ff6ff95","after":null,"ref":"refs/heads/godoc","pushedAt":"2023-12-28T15:51:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"20718b1e48c2870a81b0e3423ab17a744ff6ff95","ref":"refs/heads/godoc","pushedAt":"2023-12-27T22:23:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add package godoc\n\nSo that pkg.go.dev and `go doc` have something to show.\nCopying the first sentence from the README for brevity.","shortMessageHtmlLink":"add package godoc"}},{"before":"98951116a14f42a01293aa61cc18e48f8fb56793","after":null,"ref":"refs/heads/asm-comments","pushedAt":"2023-12-25T22:33:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"98951116a14f42a01293aa61cc18e48f8fb56793","ref":"refs/heads/asm-comments","pushedAt":"2023-12-25T21:57:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"support inline comments in asm #include lines\n\nThat is, the assembly line\n\n    #include \"foo.h\" // bar\n\nwould make garble run into an error, as we would try to parse\nthe #include directive before we stripped comments,\neffectively trying to unquote the string\n\n    \"foo.h\" // bar\n\nrather than just the included filename\n\n    \"foo.h\"\n\nAdd test cases for asm but also cgo, while at it.\n\nFixes #812.","shortMessageHtmlLink":"support inline comments in asm #include lines"}},{"before":"85236b6938315d3f20cf763a1d55c5b1b44e1bcf","after":null,"ref":"refs/heads/gotip-newer","pushedAt":"2023-12-25T21:42:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":null,"after":"85236b6938315d3f20cf763a1d55c5b1b44e1bcf","ref":"refs/heads/gotip-newer","pushedAt":"2023-12-24T22:52:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"fix support for go1.22rc1\n\nIn early December, a new internal package linknamed from runtime\nwas introduced, internal/chacha8rand. Re-generate the tables.\n\nNote that due to the same group of CLs and refactors,\nmath/rand and net are no longer linknamed from runtime in Go 1.22.\nThey are still in Go 1.21, so keep those entries around for now.\nWe can remove math/rand/v2, as it doesn't yet exist in 1.21.\n\nFixes #820.","shortMessageHtmlLink":"fix support for go1.22rc1"}},{"before":"13949a8120c8afee8acd4fe8b1c80b3b8ae81725","after":null,"ref":"refs/heads/use-cases","pushedAt":"2023-12-06T10:25:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOiG5mAA","startCursor":null,"endCursor":null}},"title":"Activity · mvdan/garble-fork"}