syntax: parse a redirect edge case without spaces #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the input >&2>/dev/null we would incorrectly error on the `2`, as we would tokenize it as part of `2>/dev/null`, when in fact it's part of `>&2`. To fix the problem, teach wordPart that it can construct a literal even if it's a _LitRedir, the start of `N>word`. This is fine, because we already use _LitRedir as a special case where it is needed, and it should not be a special case here - otherwise the bug appears. As reported by Sora Morimoto in asdf-community/asdf-direnv#120.
riacataquian
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)