Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromiseKit/CoreLocation iOS 14 Compatibility Issues #1180

Open
Veddevoloper opened this issue Jan 7, 2021 · 1 comment
Open

PromiseKit/CoreLocation iOS 14 Compatibility Issues #1180

Veddevoloper opened this issue Jan 7, 2021 · 1 comment

Comments

@Veddevoloper
Copy link

Using PromiseKit 6.13.1 and PromiseKit/CoreLocation 6.13.1
Building with Xcode 12.2 to iOS 14 simulator and devices
PromiseKit and CoreLocation extension installed with CocoaPods

iOS 14 introduced some changes for CoreLocation that are problematic with with the current implementation of the PromiseKit CoreLocation extension.

Specifically CLLocatioinManager+Promises is using deprecated method - locationManager:didChangeAuthorizationStatus:
And, it seems because

  • (AnyPromise *)until:(BOOL(^)(CLLocation *))block
  • (void)locationManager:(CLLocationManager *)manager didChangeAuthorizationStatus:(CLAuthorizationStatus)status

Both call [manager startUpdatingLocation] before authorization has been granted, didFail:withError is called and then error block is invoked in the promise chain.

So I am wondering if there is an awareness of this issue and if so if there is a plan to fix it?

@mxcl
Copy link
Owner

mxcl commented Jun 2, 2021

Seems like our ObjC version of this is pretty behind the Swift version, someone needs to port it. I am unlikely to have time for that, haven't got an app around at the moment using these extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants