Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #16

Open
Wilt opened this issue Sep 29, 2014 · 0 comments
Open

Some suggestions #16

Wilt opened this issue Sep 29, 2014 · 0 comments

Comments

@Wilt
Copy link

Wilt commented Sep 29, 2014

Great job, just some suggestions.

For consistency I think it would be good to take a look at the ZF2 interfaces for Acl. Like for example the AclInterface. The ZF2 isAllowed method from the interface has the arguments in the following order: role, resource, privilege. I think it would be a small effort to stick to these defaults by implementing the interfaces as provided in Zend\Permissions\Acl.

It would be worth considering to support role inheritance by self referencing to the parent role like in bjyoungblood his BjyAuthorize : https://github.com/bjyoungblood/BjyAuthorize/blob/master/src/BjyAuthorize/Acl/Role.php
https://github.com/bjyoungblood/BjyAuthorize/blob/master/src/BjyAuthorize/Provider/Role/ObjectRepositoryProvider.php
There are also role interfaces available in Zend\Permissions\Acl.

https://github.com/libracms/zendframework-minimal/blob/master/library/Zend/Permissions/Acl/AclInterface.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant