Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery.type flag default value is not overridden #1495

Closed
zolia opened this issue Jan 10, 2020 · 2 comments · Fixed by #1506
Closed

discovery.type flag default value is not overridden #1495

zolia opened this issue Jan 10, 2020 · 2 comments · Fixed by #1506
Labels
component:node
Projects
Engineering

Comments

@zolia
Copy link
Contributor

zolia commented Jan 10, 2020

Problem is urfave/cli related. Not sure how to fix that not using v2 cli version.
description: urfave/cli#160
@zolia zolia added this to To do in Engineering via automation Jan 10, 2020
@tadaskay
Copy link
Member

v1 PR to solve this: urfave/cli#981

@tadaskay tadaskay mentioned this issue Jan 13, 2020
Merged
@chompomonim
Copy link
Contributor

resolved by #1506

Engineering automation moved this from Icebox to Demo Jan 14, 2020
@chompomonim chompomonim moved this from Done to Archive in Engineering Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:node
Projects
No open projects
Engineering
  
Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to cliv2 - fix string slice flags mysteriumnetwork/node
3 participants
@chompomonim @tadaskay @zolia