Skip to content

Commit

Permalink
✨ update no-deprecated-api rule for revoked deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
mysticatea committed Nov 24, 2019
1 parent b6cb9a0 commit 276a9ad
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 120 deletions.
47 changes: 0 additions & 47 deletions lib/rules/no-deprecated-api.js
Expand Up @@ -17,47 +17,6 @@ const modules = {
_stream_wrap: {
[READ]: { since: "12.0.0", replacedBy: null },
},
assert: {
deepEqual: {
[READ]: {
since: "10.0.0",
replacedBy: [
{ name: "'assert.deepStrictEqual'", supported: "1.2.0" },
{ name: "'assert.strict.deepEqual'", supported: "9.9.0" },
],
},
},
equal: {
[READ]: {
since: "10.0.0",
replacedBy: [
{ name: "'assert.strictEqual'", supported: "0.1.21" },
{ name: "'assert.strict.equal'", supported: "9.9.0" },
],
},
},
notDeepEqual: {
[READ]: {
since: "10.0.0",
replacedBy: [
{ name: "'assert.notDeepStrictEqual'", supported: "1.2.0" },
{
name: "'assert.strict.notDeepEqual'",
supported: "9.9.0",
},
],
},
},
notEqual: {
[READ]: {
since: "10.0.0",
replacedBy: [
{ name: "'assert.notStrictEqual'", supported: "0.1.21" },
{ name: "'assert.strict.notEqual'", supported: "9.9.0" },
],
},
},
},
//eslint-disable-next-line camelcase
async_hooks: {
currentId: {
Expand Down Expand Up @@ -240,12 +199,6 @@ const modules = {
lchmodSync: {
[READ]: { since: "0.4.0", replacedBy: null },
},
lchown: {
[READ]: { since: "0.4.0", replacedBy: null },
},
lchownSync: {
[READ]: { since: "0.4.0", replacedBy: null },
},
},
http: {
createClient: {
Expand Down
73 changes: 0 additions & 73 deletions tests/lib/rules/no-deprecated-api.js
Expand Up @@ -4,7 +4,6 @@
*/
"use strict"

const path = require("path")
const { RuleTester } = require("eslint")
const rule = require("../../../lib/rules/no-deprecated-api")

Expand Down Expand Up @@ -304,53 +303,6 @@ ruleTester.run("no-deprecated-api", rule, {
env: { node: true },
errors: ["'_linklist' module was deprecated since v5.0.0."],
},
{
code: "require('assert').deepEqual",
options: [{ version: "10.0.0" }],
env: { node: true },
errors: [
"'assert.deepEqual' was deprecated since v10.0.0. Use 'assert.deepStrictEqual' or 'assert.strict.deepEqual' instead.",
],
},
// https://github.com/mysticatea/eslint-plugin-node/issues/141
{
code: "require('assert').deepEqual",
options: [{ version: "6.0.0" }],
env: { node: true },
errors: [
"'assert.deepEqual' was deprecated since v10.0.0. Use 'assert.deepStrictEqual' instead.",
],
},
{
code: "require('assert').deepEqual",
options: [{ version: "1.0.0" }],
env: { node: true },
errors: ["'assert.deepEqual' was deprecated since v10.0.0."],
},
{
code: "require('assert').equal",
options: [{ version: "10.0.0" }],
env: { node: true },
errors: [
"'assert.equal' was deprecated since v10.0.0. Use 'assert.strictEqual' or 'assert.strict.equal' instead.",
],
},
{
code: "require('assert').notDeepEqual",
options: [{ version: "10.0.0" }],
env: { node: true },
errors: [
"'assert.notDeepEqual' was deprecated since v10.0.0. Use 'assert.notDeepStrictEqual' or 'assert.strict.notDeepEqual' instead.",
],
},
{
code: "require('assert').notEqual",
options: [{ version: "10.0.0" }],
env: { node: true },
errors: [
"'assert.notEqual' was deprecated since v10.0.0. Use 'assert.notStrictEqual' or 'assert.strict.notEqual' instead.",
],
},
{
code: "require('async_hooks').currentId;",
options: [{ version: "8.2.0" }],
Expand Down Expand Up @@ -445,18 +397,6 @@ ruleTester.run("no-deprecated-api", rule, {
env: { node: true },
errors: ["'fs.lchmodSync' was deprecated since v0.4.0."],
},
{
code: "require('fs').lchown;",
options: [{ version: "0.4.0" }],
env: { node: true },
errors: ["'fs.lchown' was deprecated since v0.4.0."],
},
{
code: "require('fs').lchownSync;",
options: [{ version: "0.4.0" }],
env: { node: true },
errors: ["'fs.lchownSync' was deprecated since v0.4.0."],
},
{
code: "require('http').createClient;",
options: [{ version: "0.10.0" }],
Expand Down Expand Up @@ -1003,18 +943,5 @@ ruleTester.run("no-deprecated-api", rule, {
"'Buffer()' was deprecated since v6.0.0. Use 'Buffer.alloc()' or 'Buffer.from()' instead.",
],
},

// https://github.com/mysticatea/eslint-plugin-node/issues/176
{
filename: path.resolve(
__dirname,
"../../fixtures/no-deprecated-api/gte4/test.js"
),
code: "require('assert').equal",
env: { node: true },
errors: [
"'assert.equal' was deprecated since v10.0.0. Use 'assert.strictEqual' instead.",
],
},
],
})

0 comments on commit 276a9ad

Please sign in to comment.