From 276a9ad0fa8d6db224aae6fe6d35146a3fac9377 Mon Sep 17 00:00:00 2001 From: Toru Nagashima Date: Sun, 24 Nov 2019 19:34:20 +0900 Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20update=20no-deprecated-api=20rule?= =?UTF-8?q?=20for=20revoked=20deprecations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/rules/no-deprecated-api.js | 47 ------------------ tests/lib/rules/no-deprecated-api.js | 73 ---------------------------- 2 files changed, 120 deletions(-) diff --git a/lib/rules/no-deprecated-api.js b/lib/rules/no-deprecated-api.js index 1c4cf03a..68ae6953 100644 --- a/lib/rules/no-deprecated-api.js +++ b/lib/rules/no-deprecated-api.js @@ -17,47 +17,6 @@ const modules = { _stream_wrap: { [READ]: { since: "12.0.0", replacedBy: null }, }, - assert: { - deepEqual: { - [READ]: { - since: "10.0.0", - replacedBy: [ - { name: "'assert.deepStrictEqual'", supported: "1.2.0" }, - { name: "'assert.strict.deepEqual'", supported: "9.9.0" }, - ], - }, - }, - equal: { - [READ]: { - since: "10.0.0", - replacedBy: [ - { name: "'assert.strictEqual'", supported: "0.1.21" }, - { name: "'assert.strict.equal'", supported: "9.9.0" }, - ], - }, - }, - notDeepEqual: { - [READ]: { - since: "10.0.0", - replacedBy: [ - { name: "'assert.notDeepStrictEqual'", supported: "1.2.0" }, - { - name: "'assert.strict.notDeepEqual'", - supported: "9.9.0", - }, - ], - }, - }, - notEqual: { - [READ]: { - since: "10.0.0", - replacedBy: [ - { name: "'assert.notStrictEqual'", supported: "0.1.21" }, - { name: "'assert.strict.notEqual'", supported: "9.9.0" }, - ], - }, - }, - }, //eslint-disable-next-line camelcase async_hooks: { currentId: { @@ -240,12 +199,6 @@ const modules = { lchmodSync: { [READ]: { since: "0.4.0", replacedBy: null }, }, - lchown: { - [READ]: { since: "0.4.0", replacedBy: null }, - }, - lchownSync: { - [READ]: { since: "0.4.0", replacedBy: null }, - }, }, http: { createClient: { diff --git a/tests/lib/rules/no-deprecated-api.js b/tests/lib/rules/no-deprecated-api.js index 3d4cd3ba..ddb3b0ce 100644 --- a/tests/lib/rules/no-deprecated-api.js +++ b/tests/lib/rules/no-deprecated-api.js @@ -4,7 +4,6 @@ */ "use strict" -const path = require("path") const { RuleTester } = require("eslint") const rule = require("../../../lib/rules/no-deprecated-api") @@ -304,53 +303,6 @@ ruleTester.run("no-deprecated-api", rule, { env: { node: true }, errors: ["'_linklist' module was deprecated since v5.0.0."], }, - { - code: "require('assert').deepEqual", - options: [{ version: "10.0.0" }], - env: { node: true }, - errors: [ - "'assert.deepEqual' was deprecated since v10.0.0. Use 'assert.deepStrictEqual' or 'assert.strict.deepEqual' instead.", - ], - }, - // https://github.com/mysticatea/eslint-plugin-node/issues/141 - { - code: "require('assert').deepEqual", - options: [{ version: "6.0.0" }], - env: { node: true }, - errors: [ - "'assert.deepEqual' was deprecated since v10.0.0. Use 'assert.deepStrictEqual' instead.", - ], - }, - { - code: "require('assert').deepEqual", - options: [{ version: "1.0.0" }], - env: { node: true }, - errors: ["'assert.deepEqual' was deprecated since v10.0.0."], - }, - { - code: "require('assert').equal", - options: [{ version: "10.0.0" }], - env: { node: true }, - errors: [ - "'assert.equal' was deprecated since v10.0.0. Use 'assert.strictEqual' or 'assert.strict.equal' instead.", - ], - }, - { - code: "require('assert').notDeepEqual", - options: [{ version: "10.0.0" }], - env: { node: true }, - errors: [ - "'assert.notDeepEqual' was deprecated since v10.0.0. Use 'assert.notDeepStrictEqual' or 'assert.strict.notDeepEqual' instead.", - ], - }, - { - code: "require('assert').notEqual", - options: [{ version: "10.0.0" }], - env: { node: true }, - errors: [ - "'assert.notEqual' was deprecated since v10.0.0. Use 'assert.notStrictEqual' or 'assert.strict.notEqual' instead.", - ], - }, { code: "require('async_hooks').currentId;", options: [{ version: "8.2.0" }], @@ -445,18 +397,6 @@ ruleTester.run("no-deprecated-api", rule, { env: { node: true }, errors: ["'fs.lchmodSync' was deprecated since v0.4.0."], }, - { - code: "require('fs').lchown;", - options: [{ version: "0.4.0" }], - env: { node: true }, - errors: ["'fs.lchown' was deprecated since v0.4.0."], - }, - { - code: "require('fs').lchownSync;", - options: [{ version: "0.4.0" }], - env: { node: true }, - errors: ["'fs.lchownSync' was deprecated since v0.4.0."], - }, { code: "require('http').createClient;", options: [{ version: "0.10.0" }], @@ -1003,18 +943,5 @@ ruleTester.run("no-deprecated-api", rule, { "'Buffer()' was deprecated since v6.0.0. Use 'Buffer.alloc()' or 'Buffer.from()' instead.", ], }, - - // https://github.com/mysticatea/eslint-plugin-node/issues/176 - { - filename: path.resolve( - __dirname, - "../../fixtures/no-deprecated-api/gte4/test.js" - ), - code: "require('assert').equal", - env: { node: true }, - errors: [ - "'assert.equal' was deprecated since v10.0.0. Use 'assert.strictEqual' instead.", - ], - }, ], })