From e5aee3c86d0f33788c9a11f9c3e01d8083291513 Mon Sep 17 00:00:00 2001 From: Toru Nagashima Date: Thu, 23 May 2019 19:13:49 +0900 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20support=20`*`=20in=20`engines.no?= =?UTF-8?q?de`=20(fixes=20#155)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- package.json | 2 +- .../no-unsupported-features--ecma/star/package.json | 7 +++++++ tests/lib/rules/no-unsupported-features/es-syntax.js | 10 ++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 tests/fixtures/no-unsupported-features--ecma/star/package.json diff --git a/package.json b/package.json index b979631b..786c1259 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "ignore": "^5.1.1", "minimatch": "^3.0.4", "resolve": "^1.10.1", - "semver": "^6.0.0" + "semver": "^6.1.0" }, "devDependencies": { "@mysticatea/eslint-plugin": "^10.0.3", diff --git a/tests/fixtures/no-unsupported-features--ecma/star/package.json b/tests/fixtures/no-unsupported-features--ecma/star/package.json new file mode 100644 index 00000000..c76d9bcf --- /dev/null +++ b/tests/fixtures/no-unsupported-features--ecma/star/package.json @@ -0,0 +1,7 @@ +{ + "private": true, + "name": "test", + "engines": { + "node": "*" + } +} diff --git a/tests/lib/rules/no-unsupported-features/es-syntax.js b/tests/lib/rules/no-unsupported-features/es-syntax.js index 88e2f4f9..6aebb907 100644 --- a/tests/lib/rules/no-unsupported-features/es-syntax.js +++ b/tests/lib/rules/no-unsupported-features/es-syntax.js @@ -2478,6 +2478,16 @@ ruleTester.run( }, ], }, + { + filename: fixture("star/a.js"), + code: '"use strict"; let a = 1', + errors: [ + { + messageId: "no-block-scoped-variables-strict", + data: { supported: "4.0.0", version: "*" }, + }, + ], + }, { code: "var a = async () => 1", options: [{ version: "7.1.0" }],