.eslintignore

@@ -1,3 +1,6 @@
-/node_modules
+!.*
 
-!.eslintrc.*
+/.nyc_output
+/coverage
+/docs
+/node_modules

.eslintrc.js

@@ -8,6 +8,22 @@ const version = require("./package.json").version
 
 module.exports = {
     extends: ["plugin:@mysticatea/es2015", "plugin:@mysticatea/+eslint-plugin"],
+    rules: {
+        "@mysticatea/eslint-plugin/test-case-property-ordering": [
+            "error",
+            [
+                "filename",
+                "code",
+                "output",
+                "options",
+                "parser",
+                "parserOptions",
+                "globals",
+                "env",
+                "errors",
+            ],
+        ],
+    },
     overrides: [
         {
             files: ["**/rules/*.js"],
@@ -42,5 +58,16 @@ module.exports = {
                 ],
             },
         },
+        {
+            files: ["**/rules/prefer-promises/*.js"],
+            rules: {
+                "@mysticatea/eslint-plugin/require-meta-docs-url": [
+                    "error",
+                    {
+                        pattern: `https://github.com/mysticatea/eslint-plugin-node/blob/v${version}/docs/rules/prefer-promises/{{name}}.md`,
+                    },
+                ],
+            },
+        },
     ],
 }

.nycrc

@@ -0,0 +1,14 @@
+{
+    "include": [
+        "lib/**/*.js"
+    ],
+    "exclude": [
+        "lib/rules/no-hide-core-modules.js",
+        "lib/rules/no-unsupported-features.js"
+    ],
+    "reporter": [
+        "lcov",
+        "text"
+    ],
+    "sourceMap": true
+}

.travis.yml

@@ -1,39 +1,33 @@
-sudo: false
-
 os:
   - linux
   - osx
   - windows
 
 language: node_js
 node_js:
-  - "6.0.0"
-  - "6"
-  - "8"
+  - "8.10.0"
   - "10"
-  - "11"
+  - "12"
 
-env:
-  - ESLINT_VERSION=4
-  - ESLINT_VERSION=5
+# env:
+#   - ESLINT_VERSION=5
+#   - ESLINT_VERSION=6
 
-matrix:
-  exclude:
-    # ESLint 5 supports Node.js 6.14.0 and up.
-    - node_js: "6.0.0"
-      env: ESLINT_VERSION=5
-    # Reduce build jobs.
-    - os: osx
-      env: ESLINT_VERSION=4
-    - os: windows
-      env: ESLINT_VERSION=4
+# matrix:
+#   exclude:
+#     # Reduce build jobs.
+#     - os: osx
+#       env: ESLINT_VERSION=6
+#     - os: windows
+#       env: ESLINT_VERSION=6
 
 before_script:
   - npm i --no-save async
-  - npm i --no-save eslint@$ESLINT_VERSION; true
+  # - if [ $ESLINT_VERSION = "5" ]; then npm i --no-save eslint@^5.0.0; else true; fi
 
 script:
-  - if [ $ESLINT_VERSION = "5" ]; then npm run lint; else true; fi
+  # - if [ $ESLINT_VERSION = "5" ]; then npm run -s lint; else true; fi
+  - npm run -s lint
   - npm test
 
 after_success:

README.md

@@ -14,23 +14,29 @@ Additional ESLint's rules for Node.js
 $ npm install --save-dev eslint eslint-plugin-node
 ```
 
-- Requires Node.js `>=6.0.0`
-- Requires ESLint `>=4.19.1` (`plugin:node/recommended` preset requires `>=5.0.0`)
+- Requires Node.js `>=8.10.0`
+- Requires ESLint `>=5.16.0`
 
 **Note:** It recommends a use of [the "engines" field of package.json](https://docs.npmjs.com/files/package.json#engines). The "engines" field is used by `node/no-unsupported-features/*` rules.
 
 **.eslintrc.json** (An example)
 
 ```json
 {
-    "extends": ["eslint:recommended", "plugin:node/recommended"],
+    "extends": [
+        "eslint:recommended",
+        "plugin:node/recommended"
+    ],
     "rules": {
         "node/exports-style": ["error", "module.exports"],
+        "node/file-extension-in-import": ["error", "always"],
         "node/prefer-global/buffer": ["error", "always"],
         "node/prefer-global/console": ["error", "always"],
         "node/prefer-global/process": ["error", "always"],
         "node/prefer-global/url-search-params": ["error", "always"],
-        "node/prefer-global/url": ["error", "always"]
+        "node/prefer-global/url": ["error", "always"],
+        "node/prefer-promises/dns": "error",
+        "node/prefer-promises/fs": "error"
     }
 }
 ```
@@ -41,8 +47,9 @@ $ npm install --save-dev eslint eslint-plugin-node
 {
     "name": "your-module",
     "version": "1.0.0",
+    "type": "commonjs",
     "engines": {
-        "node": ">=6.0.0"
+        "node": ">=8.10.0"
     }
 }
 ```
@@ -57,18 +64,18 @@ $ npm install --save-dev eslint eslint-plugin-node
 
 | Rule ID | Description |    |
 |:--------|:------------|:--:|
-| [node/no-extraneous-import](./docs/rules/no-extraneous-import.md) | disallow `import` declarations of extraneous packages |  |
-| [node/no-extraneous-require](./docs/rules/no-extraneous-require.md) | disallow `require()` expressions of extraneous packages | ⭐️ |
-| [node/no-missing-import](./docs/rules/no-missing-import.md) | disallow `import` declarations of missing files |  |
-| [node/no-missing-require](./docs/rules/no-missing-require.md) | disallow `require()` expressions of missing files | ⭐️ |
-| [node/no-unpublished-bin](./docs/rules/no-unpublished-bin.md) | disallow 'bin' files which are ignored by npm | ⭐️ |
-| [node/no-unpublished-import](./docs/rules/no-unpublished-import.md) | disallow `import` declarations of private things |  |
-| [node/no-unpublished-require](./docs/rules/no-unpublished-require.md) | disallow `require()` expressions of private things | ⭐️ |
+| [node/no-extraneous-import](./docs/rules/no-extraneous-import.md) | disallow `import` declarations which import extraneous modules | ⭐️ |
+| [node/no-extraneous-require](./docs/rules/no-extraneous-require.md) | disallow `require()` expressions which import extraneous modules | ⭐️ |
+| [node/no-missing-import](./docs/rules/no-missing-import.md) | disallow `import` declarations which import non-existence modules | ⭐️ |
+| [node/no-missing-require](./docs/rules/no-missing-require.md) | disallow `require()` expressions which import non-existence modules | ⭐️ |
+| [node/no-unpublished-bin](./docs/rules/no-unpublished-bin.md) | disallow `bin` files that npm ignores | ⭐️ |
+| [node/no-unpublished-import](./docs/rules/no-unpublished-import.md) | disallow `import` declarations which import private modules | ⭐️ |
+| [node/no-unpublished-require](./docs/rules/no-unpublished-require.md) | disallow `require()` expressions which import private modules | ⭐️ |
 | [node/no-unsupported-features/es-builtins](./docs/rules/no-unsupported-features/es-builtins.md) | disallow unsupported ECMAScript built-ins on the specified version | ⭐️ |
 | [node/no-unsupported-features/es-syntax](./docs/rules/no-unsupported-features/es-syntax.md) | disallow unsupported ECMAScript syntax on the specified version | ⭐️ |
 | [node/no-unsupported-features/node-builtins](./docs/rules/no-unsupported-features/node-builtins.md) | disallow unsupported Node.js built-in APIs on the specified version | ⭐️ |
 | [node/process-exit-as-throw](./docs/rules/process-exit-as-throw.md) | make `process.exit()` expressions the same code path as `throw` | ⭐️ |
-| [node/shebang](./docs/rules/shebang.md) | enforce the correct usage of shebang | ⭐️✒️ |
+| [node/shebang](./docs/rules/shebang.md) | suggest correct usage of shebang | ⭐️✒️ |
 
 ### Best Practices
 
@@ -81,13 +88,16 @@ $ npm install --save-dev eslint eslint-plugin-node
 | Rule ID | Description |    |
 |:--------|:------------|:--:|
 | [node/exports-style](./docs/rules/exports-style.md) | enforce either `module.exports` or `exports` |  |
+| [node/file-extension-in-import](./docs/rules/file-extension-in-import.md) | enforce the style of file extensions in `import` declarations | ✒️ |
 | [node/prefer-global/buffer](./docs/rules/prefer-global/buffer.md) | enforce either `Buffer` or `require("buffer").Buffer` |  |
 | [node/prefer-global/console](./docs/rules/prefer-global/console.md) | enforce either `console` or `require("console")` |  |
 | [node/prefer-global/process](./docs/rules/prefer-global/process.md) | enforce either `process` or `require("process")` |  |
 | [node/prefer-global/text-decoder](./docs/rules/prefer-global/text-decoder.md) | enforce either `TextDecoder` or `require("util").TextDecoder` |  |
 | [node/prefer-global/text-encoder](./docs/rules/prefer-global/text-encoder.md) | enforce either `TextEncoder` or `require("util").TextEncoder` |  |
 | [node/prefer-global/url-search-params](./docs/rules/prefer-global/url-search-params.md) | enforce either `URLSearchParams` or `require("url").URLSearchParams` |  |
 | [node/prefer-global/url](./docs/rules/prefer-global/url.md) | enforce either `URL` or `require("url").URL` |  |
+| [node/prefer-promises/dns](./docs/rules/prefer-promises/dns.md) | enforce `require("dns").promises` |  |
+| [node/prefer-promises/fs](./docs/rules/prefer-promises/fs.md) | enforce `require("fs").promises` |  |
 
 ### Deprecated rules
 
@@ -96,21 +106,25 @@ These rules have been deprecated in accordance with the [deprecation policy](htt
 | Rule ID | Replaced by |
 |:--------|:------------|
 | [node/no-hide-core-modules](./docs/rules/no-hide-core-modules.md) | (nothing) |
-| [node/no-unsupported-features](./docs/rules/no-unsupported-features.md) | [node/no-unsupported-features/es-syntax](./docs/rules/no-unsupported-features/es-syntax.md) and [node/no-unsupported-features/es-builtins](./docs/rules/no-unsupported-features/es-builtins.md) |
+| [node/no-unsupported-features](./docs/rules/no-unsupported-features.md) | [node/node/no-unsupported-features/es-syntax](./docs/rules/node/no-unsupported-features/es-syntax.md) and [node/node/no-unsupported-features/es-builtins](./docs/rules/node/no-unsupported-features/es-builtins.md) |
 
 <!--RULES_TABLE_END-->
 
 ## 🔧 Configs
 
-This plugin provides `plugin:node/recommended` preset config.
-This preset config:
+This plugin provides three configs:
 
-- enables the environment of ES2015 (ES6) and Node.js.
-- enables rules which are given :star: in the above table.
-- enables [no-process-exit](http://eslint.org/docs/rules/no-process-exit) rule because [the official document](https://nodejs.org/api/process.html#process_process_exit_code) does not recommend a use of `process.exit()`.
-- adds `{ecmaVersion: 2019}` into `parserOptions`.
-- adds `Atomics` and `SharedArrayBuffer` into `globals`.
-- adds this plugin into `plugins`.
+- `plugin:node/recommended` condiders both CommonJS and ES Modules. If [`"type":"module"` field](https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff#b023) existed in package.json then it considers files as ES Modules. Otherwise it considers files as CommonJS. In addition, it considers `*.mjs` files as ES Modules and `*.cjs` files as CommonJS.
+- `plugin:node/recommended-module` considers all files as ES Modules.
+- `plugin:node/recommended-script` considers all files as CommonJS.
+
+Those preset config:
+
+- enable [no-process-exit](http://eslint.org/docs/rules/no-process-exit) rule because [the official document](https://nodejs.org/api/process.html#process_process_exit_code) does not recommend a use of `process.exit()`.
+- enable plugin rules which are given :star: in the above table.
+- add `{ecmaVersion: 2019}` and etc into `parserOptions`.
+- add proper globals into `globals`.
+- add this plugin into `plugins`.
 
 ## 👫 FAQ
 

docs/rules/exports-style.md

@@ -1,4 +1,5 @@
-# enforce either `module.exports` or `exports` (exports-style)
+# node/exports-style
+> enforce either `module.exports` or `exports`
 
 `module.exports` and `exports` are the same instance by default.
 But those come to be different if one of them is modified.
@@ -13,7 +14,7 @@ exports.bar = 2
 
 In this case, `exports.bar` will be lost since only the instance of `module.exports` will be exported.
 
-## Rule Details
+## 📖 Rule Details
 
 This rule enforces the export style.
 
@@ -22,7 +23,7 @@ If you use `exports`, this rule disallows `module.exports`.
 
 You can select it by an option.
 
-## Options
+### Options
 
 This rule has a string option.
 
@@ -42,7 +43,7 @@ This rule has a string option.
 - `"exports"` requires `exports` and disallows `module.exports`.
 - `allowBatchAssign` (default is `false`) allows `module.exports = exports = obj` if this is `true`.
 
-### module.exports
+#### module.exports
 
 Examples of :-1: **incorrect** code for the `"module.exports"` option:
 
@@ -66,7 +67,7 @@ module.exports = {
 module.exports.baz = 3
 ```
 
-### exports
+#### exports
 
 Examples of :-1: **incorrect** code for the `"exports"` option:
 
@@ -90,7 +91,7 @@ exports.foo = 1
 exports.bar = 2
 ```
 
-### allowBatchAssign
+#### allowBatchAssign
 
 Examples of :+1: **correct** code for the `"exports"` and `{"allowBatchAssign": true}` option:
 
@@ -104,3 +105,8 @@ module.exports = exports = function foo() {
 
 exports.bar = 1
 ```
+
+## 🔎 Implementation
+
+- [Rule source](../../lib/rules/exports-style.js)
+- [Test source](../../tests/lib/rules/exports-style.js)