Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns.promises.setServers should be ignored from prefer-promises/dns #348

Open
titanism opened this issue Feb 3, 2023 · 1 comment
Open

Comments

@titanism
Copy link

titanism commented Feb 3, 2023

Right now you have to either use dns.promises.setServers([ ... ]) or use the ignore line.

dns.promises.setServers does not actually return a Promise, and will actually error if you call it with .then().

// eslint-disable-next-line n/prefer-promises/dns
dns.setServers([
  '...'
]);
@voxpelli
Copy link

Try eslint-plugin-n, it is the maintained version of this module.

We switched to it in eg. eslint-config-standard / standard and it is maintained by me and other members of the official ESLint community organization.

If it isn't fixed there, try creating an issue there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants