Scale parameter #352
Merged
Scale parameter #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @STRML, apologies for having to hit you with a notification but am curious if there's anything that's preventing this PR from being merged? Happy to make any required/needed changes. |
|
@STRML Bumping. Apologies again for the notification but would be super appreciative if this could be merged, or at minimum reviewed. |
|
Thanks for the clean PR. Would you mind adding a test for this param? |
|
Certainly! Should be able to push one up here shortly. |
|
Is there an update on when this will be merged / release? |
|
@STRML Bumping to see if we can get this merged. |
|
Thanks for your patience everyone. |
|
Thanks a lot! It's working! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@STRML This is the same as #217 but with the conflicts resolved (specifically the issues you had mentioned with
dist). Hopefully that can give this the green light to be merged 🙂.Credit goes to @Madisonw