Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC Errors should be nicer looking #2183

Open
ramfox opened this issue Apr 12, 2024 · 0 comments
Open

RPC Errors should be nicer looking #2183

ramfox opened this issue Apr 12, 2024 · 0 comments
Labels
c-quic-rpc

Comments

@ramfox
Copy link
Contributor

ramfox commented Apr 12, 2024 •
edited

error when running iroh blob get and a connection cannot be made:

Iroh is running
Node ID: ewrl7gvv6ndtqmtvd2s6tmblvcah3yl7mn4wyyftem7dtjkrlbvq

Fetching: ee2aaokait3lsllw7ahhffn5e5busitwjh7jw5dfimwcksk7jqjq
2024-04-12T16:30:42.008812Z ERROR quinn::endpoint: I/O error: connection closed
Error: download aborted: RpcError(A network or IO operation failed)

Even just outputting:
Error: download aborted: A network or IO operation failed is more readable than couching it in RpcError
@ramfox ramfox added this to the v0.15.0 milestone Apr 12, 2024
@rklaehn rklaehn mentioned this issue Apr 17, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
@rklaehn
fix(iroh-cli): avoid using debug formatting for rpc errors (#2203)
508a812 
## Description

fix(iroh-cli): avoid using debug formatting for rpc errors

For a human readable error message, RpcError(...) does not add anything
and makes things more confusing.

See #2183

## Notes & open questions

This fixes this in one place. Probably more...

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
@dignifiedquire dignifiedquire removed this from the v0.15.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-quic-rpc
Projects
iroh
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @ramfox