Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iroh blob add uses absolute paths instead of the relative directory #2210

Open
b5 opened this issue Apr 19, 2024 · 2 comments
Open

iroh blob add uses absolute paths instead of the relative directory #2210

b5 opened this issue Apr 19, 2024 · 2 comments
Labels
bug Something isn't working c-iroh

Comments

@b5
Copy link
Member

b5 commented Apr 19, 2024

Building collections from the root of the filesystem isn't great UX πŸ˜΅β€πŸ’«. I'd expect blob add to use the input argument as the root of the collection structure.

@b5 b5 added bug Something isn't working c-iroh labels Apr 19, 2024
@cameronfyfe
Copy link
Contributor

Looking at this further I realized the collections themselves use the relative paths, it was just the cli stdout that shows the absolute paths for everything.

@cameronfyfe
Copy link
Contributor

Seems the code that sends the progress message that prints that out is in the Store impl and at that point only has the path, it doesn't know the blob is for a collection and has a pet name in that context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c-iroh
Projects
Status: πŸ“‹ Backlog
Development

No branches or pull requests

2 participants