Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] remove useOnResolve #2226

Open
EmrysMyrddin opened this issue May 2, 2024 · 0 comments
Open

[core] remove useOnResolve #2226

EmrysMyrddin opened this issue May 2, 2024 · 0 comments

Comments

@EmrysMyrddin
Copy link
Collaborator

Context

useOnResolve plugin was created to replace onResolve hook that was previously available for Envelop plugins.

In our opinion, wrapping resolvers should ba avoided at any cost, since it introduced a lot of overhead and can introduce performance issues.

Also, Envelop aims to be a runtime plugin system. This means schema modifications should not be part of the plugin lifecycle and should be done at schema build time.

Solution

Because of the point previously exposed, we should deprecate then remove this plugin.

Additional context

This removal necessitate the refactoring of multiple plugins (mostly monitoring related):

  • apollo-tracing
  • newrelic
  • opentelemetry
  • prometheus
  • rate-limiter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant