Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractLiveQueryRootFieldCoordinates doesn't respect 'idFieldName' option. #719

Open
ianberdin opened this issue Oct 4, 2021 · 3 comments
Open

extractLiveQueryRootFieldCoordinates doesn't respect 'idFieldName' option. #719

ianberdin opened this issue Oct 4, 2021 · 3 comments

Comments

@ianberdin
Copy link

ianberdin commented Oct 4, 2021 •
edited

It looks like extractLiveQueryRootFieldCoordinates use hard coded 'id' field name instead of 'idFieldName' option.

It brokes this feature:

liveQueryStore.invalidate([
  // Invalidate query operations that select the Query,user field with the id argument
  `Query.post(pk:"ffd22")`
])
@n1ru4l
Copy link
Owner

n1ru4l commented Oct 4, 2021

@ianberdin Do you want to send a PR and test for fixing this?

@n1ru4l
Copy link
Owner

n1ru4l commented Oct 4, 2021

Also related to #616

@n1ru4l
Copy link
Owner

n1ru4l commented Oct 4, 2021

Actually thinking about this more the extractLiveQueryRootFieldCoordinates is separate from the idFieldName option. As this is an argument. The correct implementation for this is described in #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianberdin @n1ru4l