Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix design system component props #8923

Merged

Conversation

cstuncsik
Copy link
Contributor

image

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 19, 2024
@cstuncsik cstuncsik requested review from elsmr and netroy March 19, 2024 17:04
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 19, 2024

2 flaky tests on run #4419 ↗︎

0 343 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: a515051bf1
Status: Passed Duration: 03:50 💡
Started: Mar 19, 2024 8:24 PM Ended: Mar 19, 2024 8:28 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Schedule Trigger node > should execute once per second when activated Test Replay Screenshots Video

Review all test suite changes for PR #8923 ↗︎

@cstuncsik cstuncsik merged commit 7176cd1 into master Mar 20, 2024
28 checks passed
@cstuncsik cstuncsik deleted the n8n-7272-get-rid-of-design-system-component-warnings branch March 20, 2024 04:10
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
@janober
Copy link
Member

janober commented Mar 20, 2024

Got released with n8n@1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants