Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebook/magazines missing files in release #2624

Open
EDChurly opened this issue Feb 12, 2019 · 15 comments
Open

ebook/magazines missing files in release #2624

EDChurly opened this issue Feb 12, 2019 · 15 comments

Comments

@EDChurly
Copy link

###Expected behaviour
Created release has Par2 files and the actual file, as per post on Usenet.

###Actual behaviour
Created release only has Par2 files and missing the PDF in a.b.e-book.magazines

###Steps to reproduce the behaviour
Many releases in a.b.e-book.magazines, mostly from poster SinnerG SinnerG@somewhere.nl are created with 5 files only, but miss the actual PDF file in the release.

For example.
Your.Home.and.Garden.TruePDF-March.2019
Only contains files:
image

Other examples:
Your.Home.and.Garden.TruePDF-March.2019
Yachts.and.Yachting.TruePDF-March.2019
Selfbuilder.and.Homemaker.TruePDF-January.February.2019
Linux.Magazine.TruePDF-March.2019
Digital.Photographer-Issue.210.2019

However, confirmed on usenet the post contains the PDF also.

Suspect this is a regex issue.

@niel
Copy link
Contributor

niel commented Feb 22, 2019

What's the subject of the article containing the actual PDF file?

@EDChurly
Copy link
Author

EDChurly commented Feb 23, 2019

Here is a recent example

image

This was indexed as
image

@EDChurly
Copy link
Author

To answer the question: [New.Scientist-23.February.2019] - "New.Scientist-23.February.2019.pdf" yEnc - 36.25 MB(1/113)

@niel
Copy link
Contributor

niel commented Feb 23, 2019

Thanks. Needed to confirm they were using the same format.

I've been looking through the code but haven't found anything yet.

@Bart39
Copy link
Contributor

Bart39 commented Feb 23, 2019

I’ll take a look, I have a big regex update to do soon

@Bart39
Copy link
Contributor

Bart39 commented Feb 23, 2019

image

edit this collection regex (search "magazine" as there's only one for this group) and edit the regex as follows:

/^(?P<match0>\[.+?\] - ").+?" yEnc(\s+-\s+\d+[,.]\d+ [mMkKgG][bB])?$/
as a temporary workaround until i do my updates

NB: this will only affect newly created collections not existing ones

@niel
Copy link
Contributor

niel commented Feb 23, 2019

Thanks @Bart39

@EDChurly
Copy link
Author

Thanks! I have applied it. Will let you know how it goes.

@EDChurly
Copy link
Author

Applied the regex but still seem to be getting new releases without the PDF, particularly from poster SinnerG.

@Bart39
Copy link
Contributor

Bart39 commented Feb 24, 2019

Do you have an example of the subject ?

@EDChurly
Copy link
Author

Pretty much any post by SinnerG or the example above.

Another example here.

image

image

The regex looks like it should work, but the index never includes the pdf. I've checked for a blacklist on pdf etc..

Subject is [Time.International.Edition-04.March.2019] - "Time.International.Edition-04.March.2019.pdf" yEnc - 9.86 MB(1/31)

@Bart39
Copy link
Contributor

Bart39 commented Mar 2, 2019

also change this release naming regex using the same pattern
image

FYI - regexes are cached for 15 mins so you wont see an immediate change - i suggest at least restarting tmux/screen whichever you use and it might be best to reset the group.

image

@EDChurly
Copy link
Author

EDChurly commented Mar 2, 2019

Thanks

I seem to have an issue elsewhere.. will continue to investigate.

I still dont get a PDF included, and the release names are not correct.

image

@Bart39
Copy link
Contributor

Bart39 commented Mar 2, 2019

correction on the release naming:

^\[(?P<match0>.+?)\] - ".+?" yEnc(\s+-\s+\d+[,.]\d+ [mMkKgG][bB])?$

@EDChurly
Copy link
Author

EDChurly commented Mar 3, 2019

Thanks, the title seems better. But underlying issue for me is still there, no PDF (or nzb) in the release and the title is the par2 file. Doesn't seem to happen for any other poster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants