Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many releases get incorrectly renamed (Also see Issue #2609) #2664

Open
SenTzu01 opened this issue May 3, 2023 · 0 comments
Open

Many releases get incorrectly renamed (Also see Issue #2609) #2664

SenTzu01 opened this issue May 3, 2023 · 0 comments

Comments

@SenTzu01
Copy link

SenTzu01 commented May 3, 2023

###Expected behaviour
unique ID value of a release stored in DB table release_unique

###Actual behaviour
Same value is stored for many releases

###Steps to reproduce the behaviour
Simply run Tmux with Fix Release Names enabled and PostProcess Additional: All

Cause:
[v0.8.22.0]
nzedb\ReleaseExtra.php line 48:
$uniqueId = (int)$general->get('unique_id')->getShortName();
Method getShortName produces a number value that exceeds PHP Max integer length. Typecasting to int produces an integer overflow resulting in the same integer across releases.
IMHO the value can be stored in the DB as-is (Not typecasted to int).

Fix:
nzedb\ReleaseExtra.php line 48:
$uniqueId = $general->get('unique_id')->getShortName();

also:
if (isset($uniqueId) && strlen($uniqueId) > 1)
provides for better validity checking of shortName in the xml.

This fix seems to produce a unique ID per release allowing individual matching of releases.

@SenTzu01 SenTzu01 changed the title Many releases matched to incorrect searchname Many releases get incorrectly renamed (Also see Issue #2609) May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant