New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeLineHeaders renders in the wrong position together with react-hot-loader #607
Comments
Here is a codesandbox for repro: https://codesandbox.io/s/react-hot-loader-o4sgz |
An incorrect, but a functional solution to this is replacing the comparison with:
thus using the name of the component. |
@westn please feel free to submit a PR make this work with rhr. Otherwise, I am not going to spend resources on this since it is not related to the library itself... |
I am reopening this since now I am facing the same issue with a new codebase. |
@westn tried your solution but no luck with this solution |
released in 0.26.4 |
Describe the bug
Using react-hot-loader together with a custom TimeLineHeader will cause the custom component to render under
.rct-scroll
instead of replacing the original.rct-header-root
To Reproduce
Use react-calendar-timeline inside a project with react-hot-loader (https://github.com/gaearon/react-hot-loader)
Create a TimeLine with a custom TimelineHeader, e.g., with the basic example.
(I might be able to add a working example a bit later)
Expected behavior
Expect it to replace the custom header as intended.
From what I've found it seems to be related to this comparison:
react-calendar-timeline/src/lib/Timeline.js
Line 915 in a3ce705
Something which already was discussed for other react-hot-loader issues in gaearon/react-hot-loader#304
Library Version
0.25.4
Desktop (please complete the following information):
Additional context
It seems like it's somewhat related to react-hot-loader, but something that they don't seem willing to fix.
The text was updated successfully, but these errors were encountered: