Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to identify shebang when it has initial spaces #1690

Closed
honggyukim opened this issue May 1, 2023 · 0 comments · Fixed by #1697 · May be fixed by #1789
Closed

unable to identify shebang when it has initial spaces #1690

honggyukim opened this issue May 1, 2023 · 0 comments · Fixed by #1697 · May be fixed by #1789
Labels
bug good first issue language support

Comments

@honggyukim
Copy link
Collaborator

uftrace detects shebang in the first line as follows.

#!/usr/bin/env python3

But if it has some whitespaces at the beginning, it can't detect the shebang as follows.

#! /usr/bin/env python3

For example, when there is a script as follows.

$ cat p-abc.py
#! /usr/bin/env python3

import os

def c():
    return os.getpid()

def b():
    return c()

def a():
    return b()

a()

The tracing result looks as follows.

$ uftrace p-abc.py
uftrace: /home/honggyu/work/uftrace/cmds/record.c:1580:find_in_path
 ERROR: Cannot trace '': No such executable file.

The shebang with whitespaces is legal so we should fix our shebang detection logic.
@yihong0618 yihong0618 mentioned this issue May 10, 2023
Closed
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 10, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
667ffe1 
Python tracing won't work when the shebang line has a space like below:

Fixed: namhyung#1690

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 mentioned this issue May 10, 2023
Merged
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 11, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
4a8a6ce 
Python tracing won't work when the shebang line has a space like below:

Fixed: namhyung#1690

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 11, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
813d6f7 
Python tracing won't work when the shebang line has a space like below:

Fixed: namhyung#1690

Signed-off-by: Yi Hong <zouzou0208@gmail.com>
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 11, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
d9c9031 
Python tracing won't work when the shebang line has a space like below:

Fixed: namhyung#1690

Signed-off-by: yihong <zouzou0208@gmail.com>
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 11, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
42dc0dd 
Python tracing won't work when the shebang line has a space like below:

Fixed: namhyung#1690
Signed-off-by: Yi Hong <zouzou0208@gmail.com>
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 11, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
3b4d928 
Python tracing won't work when the shebang line has a space like below:

  #! /usr/bin/env python3

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Yi Hong <zouzou0208@gmail.com>
namhyung pushed a commit that referenced this issue May 12, 2023
@yihong0618 @namhyung
record: skip whitespaces after shebang for scripts
6670ea5 
Python tracing won't work when the shebang line has a space like below:

  #! /usr/bin/env python3

This patch makes uftrace to understand the above shebang as well.

Fixed: #1690
Signed-off-by: Yi Hong <zouzou0208@gmail.com>
yihong0618 added a commit to yihong0618/uftrace that referenced this issue May 12, 2023
@yihong0618
record: skip whitespaces after shebang for scripts
8df0f58 
Python tracing won't work when the shebang line has a space like below:

  #! /usr/bin/env python3

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Yi Hong <zouzou0208@gmail.com>
This was referenced Jul 23, 2023
Closed
Closed
Open
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
a66cbdb 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
6aa6180 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
534a366 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
e5d3207 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
0ec6cfa 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 30, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
1ce1ff8 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Jul 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
0ff461e 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
Python tracing won't work when the shebang line has a space like below:
a1d8cb1 
" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
Python tracing won't work when the shebang line has a space like below:
5f055e5 
" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
record: skip whitespaces after shebang for scripts

Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
ce53f30 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
a1789f0 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690
Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
a5c0f43 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
0e9aafa 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
00300fd 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
GabrielKimm added a commit to GabrielKimm/uftrace that referenced this issue Aug 31, 2023
@GabrielKimm
record: skip whitespaces after shebang for scripts
7df908a 
Python tracing won't work when the shebang line has a space like below:

" #! /usr/bin/env python3 "

This patch makes uftrace to understand the above shebang as well.

Fixed: namhyung#1690

Signed-off-by: Gabriel Kim <0xgabriel.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue language support
Projects
None yet
Milestone
No milestone
2 participants
@namhyung @honggyukim