Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tui: Ask about addtional features for tui #1802

Open
kang-hyuck opened this issue Aug 11, 2023 · 5 comments · May be fixed by #1803
Open

tui: Ask about addtional features for tui #1802

kang-hyuck opened this issue Aug 11, 2023 · 5 comments · May be fixed by #1803
Labels
tui

Comments

@kang-hyuck
Copy link
Contributor

hello

I recently implemented scroll line, move halfpage in uftrace.
Those features exist in vim, and correspond to Ctrl + Y/E and Ctrl + D/U

I would like to use it in uftrace too !

  • Could I make a pull request for review?

Also, whenever I ask about new features, could I post here ?
thank you.
@honggyukim
Copy link
Collaborator

honggyukim commented Aug 12, 2023 •
edited

Hi @kang-hyuck,

I don’t clearly get what you mean but it’d be helpful if you could send a PR so that we can understand better.

You don’t actually have to open an issue when you already have a patch. Please send a PR without opening an issue in this case.

Thanks.

@honggyukim honggyukim added the tui label Aug 12, 2023
@kang-hyuck
Copy link
Contributor Author

I think it's useful when quickly search results, because It doesn't need to move cursor to top or bottom line to search next page.

  • scroll line

scroll_line

  • halfpage

halfpage

In fact, halfpage is a minor bug that I wanted to fix the cursor offset, but it does not fix cursor offset because of blank area. but, It is useful for result navigation purposes,

kang-hyuck added a commit to kang-hyuck/uftrace that referenced this issue Aug 12, 2023
@kang-hyuck
tui: Add Ctrl+u/d, Ctrl+e/y keys to move half page and scroll line
faacac7 
problem:
tui needs to move the cursor to the top and bottom to see the previous
or next page code.

solution:
Add the keys to move the page by plcaing the cursor on the result
that you are interested in.

Those are functions in vim and I implemented it.
you can move and search the result more flexibly.

Fixed: namhyung#1802
Signed-off-by: kang-hyuck <kang-hyuck@naver.com>
@kang-hyuck kang-hyuck linked a pull request Aug 12, 2023 that will close this issue
Open
@namhyung
Copy link
Owner

Sorry for the late reply. I'm not sure but it looks like a feature for experienced users..

@honggyukim
Copy link
Collaborator

It could be for experienced users, but I think it might also be useful to support more requests.

@namhyung
Copy link
Owner

We cannot copy all behaviors of vim, maybe better to keep the keys for later use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tui: Add Ctrl+u/d, Ctrl+e/y keys to move half page and scroll line kang-hyuck/uftrace
3 participants
@namhyung @honggyukim @kang-hyuck