Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'disconnect') #203

Open
p-himik opened this issue Mar 25, 2022 · 2 comments
Open

Comments

@p-himik
Copy link
Contributor

p-himik commented Mar 25, 2022

Once every few weeks I can see this error in the logs:

TypeError: Cannot read properties of undefined (reading 'disconnect')
File "node_modules/waveform-playlist/lib/Playout.js" line 73 col 21 in AudioBufferSourceNode.source.onended
this.source.disconnect();

(the line number seems to be a bit off - maybe an issue with source maps).

The relevant code is this block: https://github.com/naomiaro/waveform-playlist/blob/main/src/Playout.js#L65-L83

But I can't figure out how the error could be happening in the first place - the only way seems to be if onended is called more than once, and I can't find why that would happen. I also can't reproduce the behavior, so I have a slight suspicion it might be macOS-specific (the users are on macOS).

Do you have any clue on why that error could appear?

@naomiaro
Copy link
Owner

hmm do you know which version of waveform-playlist this app is using?

@p-himik
Copy link
Contributor Author

p-himik commented Mar 25, 2022

4.3.3, and I've been seeing that error since 4.1 or so (right when I started using waveform-playlist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants