Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to drag annotations when automatic scroll is enabled #211

Open
p-himik opened this issue May 9, 2022 · 0 comments
Open

Unable to drag annotations when automatic scroll is enabled #211

p-himik opened this issue May 9, 2022 · 0 comments

Comments

@p-himik
Copy link
Contributor

p-himik commented May 9, 2022

To reproduce:

  1. Go to https://naomiaro.github.io/waveform-playlist/annotations.html
  2. Enable Automatic Scroll at the bottom
  3. Scroll the waveform so it's not at the starting position
  4. Try dragging any annotation

Observed behavior: the waveform scrolling position is reset back to 0.
Expected behavior: the scrolling should not be affected at all by starting annotation dragging. Ideally, dragging an annotation close to a boundary of the player would scroll the waveform in the correct direction, but this probably deserves a separate feature request.

The root cause is that ScrollHook changes the position even when the playlist.isPlaying() is false, without any additional checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant