Allow throwing a SyntaxError

[idan-at]

Hey,

Relatd to swc-project/swc#2650

I'd like to refine swc error handling and throw a SyntaxError instead of an Error.

I see here that some global JS errors are supported, but not SyntaxErrorr.

Any objections to support it?

If you're fine with adding it, I can contribute.

EDIT: I see napi doesn't have an API for that :( Any suggestions?

[Brooooooklyn]

The original Node-API doesn't expose ability to create SyntaxError: https://nodejs.org/api/n-api.html#napi_create_type_error

[idan-at]

you're correct, I'm working on it :)

[Brooooooklyn]

See https://github.com/napi-rs/napi-rs/releases/tag/napi%401.7.8

There is a workaround for this scenario

[idan-at]

thank you! now that I take a look better, seems like swc actually needs create_syntax_error (here).

do you think we need to add it in a similar way or wait for the napi PR to be merged & deployed?

[idan-at]

@Brooooooklyn hey,

nodejs/node#40736 was merged and released in v17.2.0 (nodejs/node#40983).

I'd be happy to contribute to napi-rs with this new addition. Can you please guide me?

should I just add it here under the napi8 feature?

[Brooooooklyn]

should I just add it here under the napi8 feature?

And here https://github.com/napi-rs/napi-rs/blob/main/crates/napi/src/env.rs#L650