Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Cargo.lock to github #13

Closed
alx-alexpark opened this issue Aug 17, 2023 · 2 comments
Closed

Commit Cargo.lock to github #13

alx-alexpark opened this issue Aug 17, 2023 · 2 comments
Labels
C-feature Category: feature. This is adding a new feature.

Comments

@alx-alexpark
Copy link

It is helpful to people packaging Narrowlink for different distributions if you could remove Cargo.lock from your .gitignore and commit it to git.

NixOS/nixpkgs#248723 (comment)
@SajjadPourali
Copy link
Contributor

SajjadPourali commented Aug 17, 2023 •
edited

Sounds good! Please feel free to create the PR.

For the reference: Why do binaries have Cargo.lock in version control, but not libraries?

@SajjadPourali SajjadPourali added the C-feature Category: feature. This is adding a new feature. label Aug 17, 2023
@SajjadPourali SajjadPourali mentioned this issue Aug 17, 2023
Merged
@SajjadPourali
Copy link
Contributor

SajjadPourali commented Aug 17, 2023 •
edited

Done - 37def5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category: feature. This is adding a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SajjadPourali @alx-alexpark