Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup TSC. ES6 ./src update #6582

Closed
shaynababe opened this issue Apr 11, 2023 · 3 comments
Closed

Rollup TSC. ES6 ./src update #6582

shaynababe opened this issue Apr 11, 2023 · 3 comments
Labels
invalid duplicate or incorrectly filed source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Milestone

Comments

@shaynababe
Copy link

testing update code

Im not sure this is helpful for NASA i hope it is

the code based does have some errors based on the github code maybe it is not used in the production bld , not all of it
rollup.config.js.txt

I now have babel 8 working and eslint up and running the TSC code has far less errors and much smaller
I have to bundle the code in segments my computer has memory node fails , this is still in work, Commonjs has commonjs[{strictRequires:'false'},{transformMixedEsModules:'true'}],
to assist rollup has changes to the code also how it does bundles and what plugin you have , Bable and eslint will be very helpful in getting error corrected before bundled
tserr.txt
the Plugin got done still have to review, it does not appear to be like api

@shaynababe shaynababe added the type:maintenance tests, chores, or project maintenance label Apr 11, 2023
@shaynababe
Copy link
Author

shaynababe commented Apr 12, 2023

the bundle now uses cache and a bit more memory 24gb it now has compile errors
ploterr.txt

The only way to used mixed modules is install, it now show error in module def
import ts2 from "rollup-plugin-typescript2"
https://github.com/ezolenko/rollup-plugin-typescript2

src/plugins/plot/lib/eventHelpers.js(24,1): error TS9005: Declaration emit for this file requires using private name 'listenTo'. An explicit type annotation may unblock declaration emit.

src/plugins/plot/lib/eventHelpers.js(24,1): error TS9005: Declaration emit for this file requires using private name 'stopListening'. An explicit type annotation may unblock declaration emit.

[!] (plugin rpt2) RollupError: Failed to compile. Check the logs above.
src/plugins/plot/pluginSpec.js

eventHelpers.js.txt
pluginSpec.js.txt

what ?
/* eslint-disable no-undef */

 /**
         * MCT's annotation API that enables
         * human-created comments and categorization linked to data products
         * @type {module:openmct.AnnotationAPI}
         * @memberof module:openmct.MCT#
         * @name annotation
         */
        this.annotation = new api.AnnotationAPI(this);

        // Plugins that are installed by default
        this.install(this.plugins.Plot());

@shaynababe
Copy link
Author

the software is a mix of JS various version , Vue 1 , html, mix various version with syntax errors
roll up plugs to include the mixed format is to create a TS bundle that sort of works

I have been reviewing MTC.js the build file
The bundle will have to be manual the automated system can happen later

It is not ready for Vite or rollup to many file types and formats errors, This is the webpack method use what you have and make it work, it appears to work the webpage runs so far so good, webpack is fine

The package cannot use the current tools eslint and bable you have to create a new workspace to work on MCT, This is the current effort
cache and memory mangement has rollup now working, The bundle library method is underreview

@unlikelyzero
Copy link
Collaborator

Thank you for finding and filing this issue!

The Open MCT team has identified this issue as a duplicate of an existing issue. To follow along with that development (or contribute!), please subscribe to the following: #6591

@unlikelyzero unlikelyzero added invalid duplicate or incorrectly filed source:community Community contribution or request labels Mar 20, 2024
@unlikelyzero unlikelyzero added this to the Wont Fix milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid duplicate or incorrectly filed source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

2 participants