Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace support with include #110

Closed
jnoortheen opened this issue Dec 1, 2022 · 5 comments
Closed

namespace support with include #110

jnoortheen opened this issue Dec 1, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jnoortheen
Copy link

It would be good to have support for nested tasks. In a monorepo, subproject's tasks need to be run in their own directory. Calling them from the root directory will be convenient.

Example: https://taskfile.dev/usage/#including-other-taskfiles , this accepts dir: argument as well. That will be used as the workdir for the nested tasks

@nat-n
Copy link
Owner

nat-n commented Dec 1, 2022

Hi @jnoortheen, thanks for the feedback. Monorepo support is something I'd like poe to be better at.

Have you tried achieving this with the include option, combined with the cwd option?

Does that do what you want or is there something missing? I guess the way cwd works is a bit limited here because poe doesn't explicitly keep track of the location of the file the task was defined in, when what you really want is to set something like: cwd = "${TASK_FILE_DIR}", and maybe also to be able to configure this per pyproject.toml rather than per task?

@jnoortheen
Copy link
Author

@nat-n thanks for the quick reply. I did try include option, it would be cumbersome to define the cwd on the included task file. Since I am converting from taskfile.yml I expected the include to accept a table with cwd option.
It would be easier to call tasks from sub-modules.

@nat-n nat-n self-assigned this Dec 2, 2022
@nat-n nat-n added the enhancement New feature or request label Dec 2, 2022
@nat-n
Copy link
Owner

nat-n commented Dec 3, 2022

Yea, that makes sense. It'll be in the next release soon :)

@nat-n
Copy link
Owner

nat-n commented Dec 26, 2022

@jnoortheen This feature is now available as part of v0.17.0.

@nat-n nat-n closed this as completed Dec 26, 2022
@jnoortheen
Copy link
Author

Looks neat. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants