Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poe uses different CLI args for working directory than Poetry #212

Closed
jeraymond opened this issue Apr 17, 2024 · 2 comments
Closed

Poe uses different CLI args for working directory than Poetry #212

jeraymond opened this issue Apr 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jeraymond
Copy link
Contributor

Poetry used -C and --directory for the working directory, whereas Poe uses --root. It'd be nice if these were consistent. Would you be open to adding support for -C and --directory in addition to --root for this? If so, I'm happy to contribute a PR.
@nat-n
Copy link
Owner

nat-n commented Apr 19, 2024 •
edited

Hi @jeraymond,

Thanks for the suggestion. After thinking it over a bit I think you're right, it makes sense to align with this convention (which various unix utils also follow).

I wouldn't want this to be a breaking change, but also wouldn't want the documentation to get noisy, so I'd say the --root option should be deprecated in the sense of being removed from the documentation but still functional for backwards compatibility.

So I'd be happy to receive a PR on this.

@nat-n nat-n added the enhancement New feature or request label Apr 19, 2024
jeraymond added a commit to jeraymond/poethepoet that referenced this issue Apr 20, 2024
@jeraymond
Use -C and --directory for pyproject.toml directory path (nat-n#212)
a2a4413 
Update Poe to use args -C and --directory to find the path to the directory
with pyproject.toml. This better aligns with Poetry (which also uses -C and
--directory). Keep the --root argument as a hidden parameter for backwards
compatibility.
jeraymond added a commit to jeraymond/poethepoet that referenced this issue Apr 20, 2024
@jeraymond
Use -C and --directory for pyproject.toml directory path (nat-n#212)
6b35be6 
Update Poe to use args -C and --directory to find the path to the directory
with pyproject.toml. This better aligns with Poetry (which also uses -C and
--directory). Keep the --root argument as a hidden parameter for backwards
compatibility.
@nat-n
Copy link
Owner

nat-n commented Apr 27, 2024 •
edited

Shipped in 0.26.0 🚀

@nat-n nat-n closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeraymond @nat-n