Zoom with Ctrl+Mousewheel doesn't work

[gsantner]

Description

Tried zooming with the numpad +/-/0 keys and neither do work.

Steps to Reproduce Issue

• Open any application created with nativefier
• Press CTRL + +/-/0
• No zoom action happens

Specifications

• Version of Nativefier (run $ nativefier --version): v7.4.0
• Version of Node.js (run $ node --version): v7.10.0
• OS: Arch
• Architecture x64

[ronjouch]

Seems legit, thanks for the report @gsantner 👍. As a workaround, non-keypad Ctrl++/-/0 do work, and Zoom In/Out actions (in the View menu) do too.

[joeytwiddle]

Ctrl-MouseWheelUp/Down also do not zoom (like they do in the browser). Not sure if related.

[derekperkins]

I can zoom using the non-keypad combinations, but the zoom resets on every click navigation. I'm using nativefier 7.4.1 for GitHub.

[eladnava]

Can confirm zoom functionality stopped working for me as well.

[ronjouch]

Zoom with Ctrl+{+/-/0} numpad keys is fixed in ts branch, which I encourage everyone to test.

To those of you willing to give this dev. branch a try, go ahead: it's ready to ship, currently being reviewed by Jia, will ship soon, so testing is extremely welcome. See the build instructions at #898 (comment) , and please report any issues with a [ts] prefix.

[eladnava]

Hi @ronjouch,
Thanks for the reply.

I've just tested with ts branch and indeed hotkey zoom works. Any pointers on how to get touchpad zoom working again like in previous versions?

[eladnava]

Turns out pinch-to-zoom (macOS touchpad) zoom is now disabled by default in newer versions of Electron:
electron/electron#12679

To re-enable, I've added the following invocation inside window.webContents.on('did-finish-load', () => {}:

window.webContents.setVisualZoomLevelLimits(1, 3);

Woohoo! 🎉

[ronjouch]

Turns out pinch-to-zoom (macOS touchpad) zoom is now disabled by default in newer versions of Electron: electron/electron#12679 To re-enable, I've added the following invocation inside window.webContents.on('did-finish-load', () => {}:

window.webContents.setVisualZoomLevelLimits(1, 3);

@eladnava thanks! I incorporated your patch in branch ts, but I don't have a mac to test it. Please check out branch ts, pull, re-build, and confirm pinch-to-zoom works. If it doesn't, suggestions welcome as to what I barfed up in 3875743 . 🙏

[eladnava]

Hi @ronjouch,
Perfect, just one thing, it would be nice if pinch-to-zoom was supported on any non-main windows (e.g. opening a link in a new nativefier window):

In mainWindow.js:

Find:

const sendParamsOnDidFinishLoad = (window) => {
        window.webContents.on('did-finish-load', () => {
            window.webContents.send('params', JSON.stringify(options));
        });
    };

Replace with:

const sendParamsOnDidFinishLoad = (window) => {
        window.webContents.on('did-finish-load', () => {
            // Re-enable zoom
            window.webContents.setVisualZoomLevelLimits(1, 3);
            window.webContents.send('params', JSON.stringify(options));
        });
    };

[ronjouch]

Perfect, just one thing, it would be nice if pinch-to-zoom was supported on any non-main windows

@eladnava true! Incorporated in ts! Thanks again!

[eladnava]

Perfect, confirmed working 🎉