Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Support macOS Mojave dark mode #733

Closed
weiran opened this issue Jan 2, 2019 · 3 comments
Closed

Support macOS Mojave dark mode #733

weiran opened this issue Jan 2, 2019 · 3 comments
Labels
feature-request mac

Comments

@weiran
Copy link

weiran commented Jan 2, 2019

Description

Electron 4.0 adds support for Mojave dark mode: electron/electron#13387. Can nativefier support this as well? Currently the window title bar is "light" grey even if the dark theme is selected on macOS.

Steps to reproduce issue

Run nativefier on any website on macOS Mojave. With dark system theme selected, nativefier should then adapt the window title bar to be dark as well.

Details

  • Are you nativefying a public website? Yes
  • Feature request? Have you looked at nativefier --help to see if an existing option could fit your needs? Yes
@ronjouch
Copy link
Contributor

ronjouch commented Jan 2, 2019

Would be cool.

Depends on #727 - Review and adapt to electron 4.0 breaking changes.

@nwoolls nwoolls mentioned this issue Apr 19, 2019
Merged
@danielkuhlwein
Copy link

I would pay for this feature. Keep up the greet work @ronjouch. I look forward to future updates!

ronjouch pushed a commit that referenced this issue Aug 22, 2019
@nwoolls @ronjouch
Support macOS 10.4+ Dark Mode, default to Electron 5.x (#796)
5433569 
Introduces a `--darwin-dark-mode-support` flag. 
(I kept the same flag used by Electron Packager.)
This required bumping Electron and Electron Packager.

Addresses:

- #733
- #727
@ronjouch
Copy link
Contributor

Closing as fixed since 5433569 .

Adam777Z pushed a commit to Adam777Z/nativefier that referenced this issue Nov 9, 2022
@nwoolls @ronjouch
Support macOS 10.4+ Dark Mode, default to Electron 5.x (nativefier#796)
a9d0b47 
Introduces a `--darwin-dark-mode-support` flag. 
(I kept the same flag used by Electron Packager.)
This required bumping Electron and Electron Packager.

Addresses:

- nativefier#733
- nativefier#727
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request mac
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronjouch @weiran @danielkuhlwein