Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV Discard policy #103

Open
7 of 11 tasks
kozlovic opened this issue Mar 15, 2022 · 0 comments
Open
7 of 11 tasks

KV Discard policy #103

kozlovic opened this issue Mar 15, 2022 · 0 comments
Assignees
Labels
client Client related work enhancement New feature or request

Comments

@kozlovic
Copy link
Member

kozlovic commented Mar 15, 2022

Overview

The discard policy should be set to "new", but really for server 2.7.2+ since only this server handles discard policy "new" correctly for KV use-case, that is with "max msgs per subject" set: this will prevent new "keys" to be added, but discard old for a given "key" allowing KV delete/purge (adding tombstone) to be added on a given "key" (subject).

The Go client has implemented a change that updates the stream's discard policy if connecting to a v2.7.2+ and find that the stream exists with discard policy "old": nats-io/nats.go#917

The behavior is documented in ADR-8.

Clients and Tools

Other Tasks

  • docs.nats.io updated
  • Update ADR to Implemented
  • Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

@kozlovic kozlovic added enhancement New feature or request client Client related work labels Mar 15, 2022
@scottf scottf removed their assignment Mar 21, 2022
@ripienaar ripienaar removed their assignment Aug 30, 2022
@Jarema Jarema removed their assignment Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client related work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants